Bug 1374561 - Allow to set log level in mach for every class derived from MozbuildObject. r?glandium draft
authorAndi-Bogdan Postelnicu <bpostelnicu@mozilla.com>
Tue, 20 Jun 2017 11:31:26 +0300
changeset 597190 93364c4ff7f3db32d8a99ecf0106e718140f2ce8
parent 597026 416c3c8c4b3db9ba96a103ce7820c9a140a3051d
child 634171 a08240377dd03181f5a99903d9cf63b6cd2b087b
push id64868
push userbmo:bpostelnicu@mozilla.com
push dateTue, 20 Jun 2017 08:38:12 +0000
reviewersglandium
bugs1374561
milestone56.0a1
Bug 1374561 - Allow to set log level in mach for every class derived from MozbuildObject. r?glandium MozReview-Commit-ID: KpNRZuHkpFe
python/mozbuild/mozbuild/base.py
python/mozbuild/mozbuild/mach_commands.py
--- a/python/mozbuild/mozbuild/base.py
+++ b/python/mozbuild/mozbuild/base.py
@@ -622,16 +622,20 @@ class MozbuildObject(ProcessExecutionMix
         return cls(self.topsrcdir, self.settings, self.log_manager,
             topobjdir=self.topobjdir)
 
     def _activate_virtualenv(self):
         self.virtualenv_manager.ensure()
         self.virtualenv_manager.activate()
 
 
+    def _set_log_level(self, verbose):
+        self.log_manager.terminal_handler.setLevel(logging.INFO if not verbose else logging.DEBUG)
+
+
 class MachCommandBase(MozbuildObject):
     """Base class for mach command providers that wish to be MozbuildObjects.
 
     This provides a level of indirection so MozbuildObject can be refactored
     without having to change everything that inherits from it.
     """
 
     def __init__(self, context):
--- a/python/mozbuild/mozbuild/mach_commands.py
+++ b/python/mozbuild/mozbuild/mach_commands.py
@@ -1543,19 +1543,16 @@ class PackageFrontend(MachCommandBase):
         object directory.  Use |mach artifact last| to see what binary artifacts
         were last used.
 
         Never build libxul again!
 
         '''
         pass
 
-    def _set_log_level(self, verbose):
-        self.log_manager.terminal_handler.setLevel(logging.INFO if not verbose else logging.DEBUG)
-
     def _make_artifacts(self, tree=None, job=None, skip_cache=False):
         state_dir = self._mach_context.state_dir
         cache_dir = os.path.join(state_dir, 'package-frontend')
 
         import which
 
         here = os.path.abspath(os.path.dirname(__file__))
         build_obj = MozbuildObject.from_environment(cwd=here)