Bug 1363428 - Use the internal reftest implementation by default on Linux and OSX, r=ato draft
authorJames Graham <james@hoppipolla.co.uk>
Fri, 16 Jun 2017 18:05:50 +0100
changeset 600219 28674aef2d0286d589d59b4f35ddb0030b623eeb
parent 600218 acbed7f6ccf423787bd598f4ba32581aa4fe6621
child 600220 576a1613005ec87cadc41d21880bcdf03334a3c0
push id65688
push userbmo:james@hoppipolla.co.uk
push dateSat, 24 Jun 2017 11:04:46 +0000
reviewersato
bugs1363428
milestone56.0a1
Bug 1363428 - Use the internal reftest implementation by default on Linux and OSX, r=ato This is faster and works better in some cases (e.g. with SVG). However it doesn't work correctly on Windows yet, so remains disabled there by default. MozReview-Commit-ID: AXyeFUGfVgx
testing/web-platform/tests/tools/wptrunner/wptrunner/wptcommandline.py
--- a/testing/web-platform/tests/tools/wptrunner/wptrunner/wptcommandline.py
+++ b/testing/web-platform/tests/tools/wptrunner/wptrunner/wptcommandline.py
@@ -391,16 +391,20 @@ def check_args(kwargs):
     if kwargs['extra_prefs']:
         missing = any('=' not in prefarg for prefarg in kwargs['extra_prefs'])
         if missing:
             print >> sys.stderr, "Preferences via --setpref must be in key=value format"
             sys.exit(1)
         kwargs['extra_prefs'] = [tuple(prefarg.split('=', 1)) for prefarg in
                                  kwargs['extra_prefs']]
 
+    if kwargs["reftest_internal"] is None:
+        # Default to the internal reftest implementation on Linux and OSX
+        kwargs["reftest_internal"] = sys.platform.startswith("linux") or sys.platform.startswith("darwin")
+
     return kwargs
 
 
 def check_args_update(kwargs):
     set_from_config(kwargs)
 
     if kwargs["product"] is None:
         kwargs["product"] = "firefox"