Bug 1374238 - add null check for nsIOService::SpeculativeConnectInternal. r=dragana draft
authorShih-Chiang Chien <schien@mozilla.com>
Mon, 19 Jun 2017 18:55:41 +0800
changeset 597286 0939e80d7ff4649d74f8db25c8ff446563861925
parent 593717 b266a8d8fd595b84a7d6218d7b8c6b7af0b5027c
child 634195 b14cf7e60a4c6e3e9a3e659c97534592da000fda
push id64893
push userbmo:schien@mozilla.com
push dateTue, 20 Jun 2017 10:45:03 +0000
reviewersdragana
bugs1374238
milestone56.0a1
Bug 1374238 - add null check for nsIOService::SpeculativeConnectInternal. r=dragana MozReview-Commit-ID: 8avSx50euMF
netwerk/base/nsIOService.cpp
--- a/netwerk/base/nsIOService.cpp
+++ b/netwerk/base/nsIOService.cpp
@@ -1820,16 +1820,18 @@ IOServiceProxyCallback::OnProxyAvailable
 }
 
 nsresult
 nsIOService::SpeculativeConnectInternal(nsIURI *aURI,
                                         nsIPrincipal *aPrincipal,
                                         nsIInterfaceRequestor *aCallbacks,
                                         bool aAnonymous)
 {
+    NS_ENSURE_ARG(aURI);
+
     bool isHTTP, isHTTPS;
     if (!(NS_SUCCEEDED(aURI->SchemeIs("http", &isHTTP)) && isHTTP) &&
         !(NS_SUCCEEDED(aURI->SchemeIs("https", &isHTTPS)) && isHTTPS)) {
         // We don't speculatively connect to non-HTTP[S] URIs.
         return NS_OK;
     }
 
     if (IsNeckoChild()) {