Bug 1373188 - Remove the redundant css toggling and update to the right css rule in browser_onboarding_hide_tours.js, r?rexboy draft
authorFischer.json <fischer.json@gmail.com>
Thu, 15 Jun 2017 18:06:54 +0800
changeset 595705 a4c9cc8f38f640030a0f34b6d58c0eb07387e329
parent 595489 fe809f57bf2287bb937c3422ed03a63740b3448b
child 633783 af1ee20ae4c3311b119050f91ef6b3d19b8c7752
push id64424
push userbmo:fliu@mozilla.com
push dateFri, 16 Jun 2017 18:31:25 +0000
reviewersrexboy
bugs1373188
milestone56.0a1
Bug 1373188 - Remove the redundant css toggling and update to the right css rule in browser_onboarding_hide_tours.js, r?rexboy MozReview-Commit-ID: 3wpRMACMCa7
browser/extensions/onboarding/content/onboarding.js
browser/extensions/onboarding/test/browser/head.js
--- a/browser/extensions/onboarding/content/onboarding.js
+++ b/browser/extensions/onboarding/content/onboarding.js
@@ -227,24 +227,21 @@ class Onboarding {
   }
 
   toggleOverlay() {
     if (this._tourItems.length == 0) {
       // Lazy loading until first toggle.
       this._loadTours(onboardingTours);
     }
 
-    this._overlay.classList.toggle("opened");
+    this._overlay.classList.toggle("onboarding-opened");
     let hiddenCheckbox = this._window.document.getElementById("onboarding-tour-hidden-checkbox");
     if (hiddenCheckbox.checked) {
       this.hide();
-      return;
     }
-
-    this._overlay.classList.toggle("onboarding-opened");
   }
 
   gotoPage(tourId) {
     let targetPageId = `${tourId}-page`;
     for (let page of this._tourPages) {
       page.style.display = page.id != targetPageId ? "none" : "";
     }
     for (let li of this._tourItems) {
--- a/browser/extensions/onboarding/test/browser/head.js
+++ b/browser/extensions/onboarding/test/browser/head.js
@@ -26,17 +26,17 @@ function promiseOnboardingOverlayLoaded(
   );
 }
 
 function promiseOnboardingOverlayOpened(browser) {
   let condition = () => {
     return ContentTask.spawn(browser, {}, function() {
       return new Promise(resolve => {
         let overlay = content.document.querySelector("#onboarding-overlay");
-        if (overlay.classList.contains("opened")) {
+        if (overlay.classList.contains("onboarding-opened")) {
           resolve(true);
           return;
         }
         resolve(false);
       });
     })
   };
   return BrowserTestUtils.waitForCondition(