Bug 1372528 - Change search settings redirects to General section of about:preferences r?jaws draft
authorRicky Chien <ricky060709@gmail.com>
Thu, 15 Jun 2017 16:22:43 +0800
changeset 595177 16b9b06292e21b1201978ce2eea23f1fd20cd6db
parent 595097 79cdd4893c4607b8ad19c41ffd4ddde2f11d0151
child 633645 711b2e87077c14aef23d1d8fda5780ebc15a44d1
push id64271
push userbmo:rchien@mozilla.com
push dateFri, 16 Jun 2017 04:04:49 +0000
reviewersjaws
bugs1372528
milestone56.0a1
Bug 1372528 - Change search settings redirects to General section of about:preferences r?jaws MozReview-Commit-ID: J5biFoOjsXX
browser/base/content/urlbarBindings.xml
browser/components/search/content/search.xml
--- a/browser/base/content/urlbarBindings.xml
+++ b/browser/base/content/urlbarBindings.xml
@@ -1595,17 +1595,17 @@ file, You can obtain one at http://mozil
                      role="link"
 #ifdef XP_WIN
                      value="&urlbar.searchSuggestionsNotification.changeSettingsWin;"
                      accesskey="&urlbar.searchSuggestionsNotification.changeSettingsWin.accesskey;"
 #else
                      value="&urlbar.searchSuggestionsNotification.changeSettingsUnix;"
                      accesskey="&urlbar.searchSuggestionsNotification.changeSettingsUnix.accesskey;"
 #endif
-                     onclick="openPreferences('general-search');"
+                     onclick="Preferences.get('browser.preferences.useOldOrganization') ? openPreferences('paneSearch') : openPreferences('general-search');"
                      control="search-suggestions-change-settings"/>
         </xul:hbox>
       </xul:deck>
       <xul:richlistbox anonid="richlistbox" class="autocomplete-richlistbox"
                        flex="1"/>
       <xul:hbox anonid="footer">
         <children/>
         <xul:vbox anonid="one-off-search-buttons"
--- a/browser/components/search/content/search.xml
+++ b/browser/components/search/content/search.xml
@@ -1467,17 +1467,23 @@
           // Make sure the engine list is refetched next time it's needed.
           this._engines = null;
         ]]></body>
       </method>
 
       <method name="showSettings">
         <body><![CDATA[
           BrowserUITelemetry.countSearchSettingsEvent(this.telemetryOrigin);
-          openPreferences("general-search", {origin: "contentSearch"});
+
+          if (Preferences.get("browser.preferences.useOldOrganization")) {
+            openPreferences("paneSearch", {origin: "contentSearch"});
+          } else {
+            openPreferences("general-search", {origin: "contentSearch"});
+          }
+
           // If the preference tab was already selected, the panel doesn't
           // close itself automatically.
           this.popup.hidePopup();
         ]]></body>
       </method>
 
       <!-- Updates the parts of the UI that show the query string. -->
       <method name="_updateAfterQueryChanged">