Bug 1372737 - Use URL base name as the default file name for save as; r=gasolin draft
authorJan Odvarko <odvarko@gmail.com>
Wed, 14 Jun 2017 10:45:51 +0200
changeset 593900 bbebbcb11c196ac87bc8162c3ecc7abb7244154b
parent 593303 a8f8e440d627d686fa8898483aa9c5da928a8fa4
child 633259 f978cacdc9b8b88a536d4f500f04b5cb014aec69
push id63857
push userjodvarko@mozilla.com
push dateWed, 14 Jun 2017 08:47:07 +0000
reviewersgasolin
bugs1372737
milestone56.0a1
Bug 1372737 - Use URL base name as the default file name for save as; r=gasolin MozReview-Commit-ID: CSyh84N9fYs
devtools/client/netmonitor/src/request-list-context-menu.js
--- a/devtools/client/netmonitor/src/request-list-context-menu.js
+++ b/devtools/client/netmonitor/src/request-list-context-menu.js
@@ -18,16 +18,17 @@ const {
   getSelectedRequest,
   getSortedRequests,
 } = require("./selectors/index");
 const { L10N } = require("./utils/l10n");
 const { showMenu } = require("./utils/menu");
 const {
   getUrlQuery,
   parseQueryString,
+  getUrlBaseName,
 } = require("./utils/request-utils");
 
 function RequestListContextMenu({
   cloneSelectedRequest,
   openStatistics,
 }) {
   this.cloneSelectedRequest = cloneSelectedRequest;
   this.openStatistics = openStatistics;
@@ -304,17 +305,17 @@ RequestListContextMenu.prototype = {
     copyString(this.selectedRequest.responseContentDataUri);
   },
 
   /**
    * Save image as.
    */
   saveImageAs() {
     let { encoding, text } = this.selectedRequest.responseContent.content;
-    let fileName = this.selectedRequest.urlDetails.baseNameWithQuery;
+    let fileName = getUrlBaseName(this.selectedRequest.url);
     let data;
     if (encoding === "base64") {
       let decoded = atob(text);
       data = new Uint8Array(decoded.length);
       for (let i = 0; i < decoded.length; ++i) {
         data[i] = decoded.charCodeAt(i);
       }
     } else {