Bug 1369900 - Part 1: Use parseXXX instead of valueOf to prevent boxing/unboxing to parse a primitive. r?Grisha draft
authorJing-wei Wu <topwu.tw@gmail.com>
Wed, 14 Jun 2017 15:36:34 +0800
changeset 593873 1f3cb4dadd3d7b8a3d9de981ab746621e1d881a0
parent 593872 0536494c3ac1317ecdf269d3f0050c6cf5b75ef1
child 593874 a8e3a3997cac50fa06b8f267feeb2f7b756415cb
push id63845
push userbmo:topwu.tw@gmail.com
push dateWed, 14 Jun 2017 08:02:56 +0000
reviewersGrisha
bugs1369900
milestone56.0a1
Bug 1369900 - Part 1: Use parseXXX instead of valueOf to prevent boxing/unboxing to parse a primitive. r?Grisha MozReview-Commit-ID: 6GFgC6E5v0d
mobile/android/tests/background/junit4/src/org/mozilla/gecko/db/LocalBrowserDBTest.java
--- a/mobile/android/tests/background/junit4/src/org/mozilla/gecko/db/LocalBrowserDBTest.java
+++ b/mobile/android/tests/background/junit4/src/org/mozilla/gecko/db/LocalBrowserDBTest.java
@@ -109,28 +109,28 @@ public class LocalBrowserDBTest {
         final BrowserDB db = new LocalBrowserDB("default");
         final ContentResolver cr = context.getContentResolver();
 
         final long rootId = getBookmarkIdFromGuid(BrowserContract.Bookmarks.MOBILE_FOLDER_GUID);
         // Create a parent folder
         final Uri parentUri = db.addBookmarkFolder(cr, FOLDER_NAME, rootId);
         assertNotNull(parentUri);
         // Get id from Uri
-        final long parentId = Long.valueOf(parentUri.getLastPathSegment());
+        final long parentId = Long.parseLong(parentUri.getLastPathSegment());
 
         // Create nested child bookmarks and folders
         // parent / bookmark-1
         //        / folder-1
         //        / folder-2 / bookmark-2
         insertBookmark("bookmark-1", null, "guid-bookmark-1", parentId, BrowserContract.Bookmarks.TYPE_BOOKMARK);
         insertBookmark("folder-1", null, "guid-folder-1", parentId, BrowserContract.Bookmarks.TYPE_FOLDER);
 
         final Uri folderUri = insertBookmark("folder-2", null, "guid-folder-2", parentId, BrowserContract.Bookmarks.TYPE_FOLDER);
         assertNotNull(folderUri);
-        final long folderId = Long.valueOf(folderUri.getLastPathSegment());
+        final long folderId = Long.parseLong(folderUri.getLastPathSegment());
         insertBookmark("bookmark-2", null, "guid-bookmark-2", folderId, BrowserContract.Bookmarks.TYPE_BOOKMARK);
 
         final String selection = BrowserContract.Bookmarks.PARENT + " = ? OR " +
                                  BrowserContract.Bookmarks.PARENT + " = ?";
         final String[] selectionArgs = { String.valueOf(parentId), String.valueOf(folderId) };
         final int childCountBeforeRemove = getRowCount(selection, selectionArgs);
         assertEquals(4, childCountBeforeRemove);
 
@@ -147,17 +147,17 @@ public class LocalBrowserDBTest {
         final BrowserDB db = new LocalBrowserDB("default");
         final ContentResolver cr = context.getContentResolver();
 
         final long rootId = getBookmarkIdFromGuid(BrowserContract.Bookmarks.MOBILE_FOLDER_GUID);
         // Create a parent folder
         final Uri parentUri = db.addBookmarkFolder(cr, FOLDER_NAME, rootId);
         assertNotNull(parentUri);
         // Get id from Uri
-        final long parentId = Long.valueOf(parentUri.getLastPathSegment());
+        final long parentId = Long.parseLong(parentUri.getLastPathSegment());
 
         // Create more than DBUtils.SQLITE_MAX_VARIABLE_NUMBER child bookmarks/folders.
         for (int i = 0; i < DBUtils.SQLITE_MAX_VARIABLE_NUMBER; ++i) {
             insertBookmark("bookmark-" + i,
                            "https://www.mozilla-" + i + ".org",
                            "guid-bookmark-" + i,
                            parentId,
                            BrowserContract.Bookmarks.TYPE_BOOKMARK);
@@ -302,17 +302,17 @@ public class LocalBrowserDBTest {
         } finally {
             cursor.close();
         }
         assertNotEquals(bookmarkId, INVALID_ID);
 
         // Create a folder
         final Uri newFolderUri = db.addBookmarkFolder(cr, FOLDER_NAME, originalParentId);
         // Get id from Uri
-        final long newParentId = Long.valueOf(newFolderUri.getLastPathSegment());
+        final long newParentId = Long.parseLong(newFolderUri.getLastPathSegment());
 
         final long originalParentLastModifiedBeforeUpdate = getModifiedDate(originalParentId);
         final long newParentLastModifiedBeforeUpdate = getModifiedDate(newParentId);
 
         // Update bookmark record
         db.updateBookmark(cr, bookmarkId, UPDATE_URL, UPDATE_TITLE, "", newParentId, originalParentId);
         cursor = db.getBookmarkById(cr, bookmarkId);
         assertNotNull(cursor);
@@ -344,17 +344,17 @@ public class LocalBrowserDBTest {
         BrowserDB db = new LocalBrowserDB("default");
         ContentResolver cr = context.getContentResolver();
 
         // Add a bookmark folder record
         final long rootFolderId = getBookmarkIdFromGuid(BrowserContract.Bookmarks.MOBILE_FOLDER_GUID);
         final long lastModifiedBeforeAdd = getModifiedDate(rootFolderId);
         final Uri folderUri = db.addBookmarkFolder(cr, FOLDER_NAME, rootFolderId);
         // Get id from Uri
-        long folderId = Long.valueOf(folderUri.getLastPathSegment());
+        long folderId = Long.parseLong(folderUri.getLastPathSegment());
 
         final Cursor cursor = db.getBookmarkById(cr, folderId);
         assertNotNull(cursor);
         try {
             assertTrue(cursor.moveToFirst());
 
             final String name = cursor.getString(cursor.getColumnIndexOrThrow(BrowserContract.Bookmarks.TITLE));
             assertEquals(name, FOLDER_NAME);
@@ -580,17 +580,17 @@ public class LocalBrowserDBTest {
     }
 
     private void testDeleteBookmarkWithSize(BrowserDB db, ContentResolver cr, String guidPrefix, int size) throws RemoteException {
         final long rootId = getBookmarkIdFromGuid(BrowserContract.Bookmarks.MOBILE_FOLDER_GUID);
         // Create a parent folder
         final Uri parentUri = db.addBookmarkFolder(cr, FOLDER_NAME, rootId);
         assertNotNull(parentUri);
         // Get id from Uri
-        final long parentId = Long.valueOf(parentUri.getLastPathSegment());
+        final long parentId = Long.parseLong(parentUri.getLastPathSegment());
 
         // Create more than DBUtils.SQLITE_MAX_VARIABLE_NUMBER child bookmarks/folders.
         for (int i = 0; i < size; ++i) {
             insertBookmark("bookmark-" + i,
                            "https://www.mozilla-" + i + ".org",
                            guidPrefix + i,
                            parentId,
                            BrowserContract.Bookmarks.TYPE_BOOKMARK);