Bug 1339690 - Part 2: Drop tests of paced timing in dom/animation/test. draft
authorBoris Chiou <boris.chiou@gmail.com>
Tue, 13 Jun 2017 13:30:58 +0800
changeset 594705 ff4bd5f5bc8de1be3d273ea1e9f4aafef19bbf1c
parent 594704 ab16cfcaeea473335b7fd3921159735cc570a729
child 594706 8790c59e9c2b2e0686439b517dc12d63b8f0d233
push id64112
push userbmo:boris.chiou@gmail.com
push dateThu, 15 Jun 2017 10:38:49 +0000
bugs1339690
milestone56.0a1
Bug 1339690 - Part 2: Drop tests of paced timing in dom/animation/test. MozReview-Commit-ID: BbfXB5MmMgE
dom/animation/test/chrome/test_animation_observers_sync.html
dom/animation/test/crashtests/1290535-1.html
dom/animation/test/crashtests/1333418-1.html
dom/animation/test/crashtests/crashtests.list
dom/animation/test/mochitest.ini
dom/animation/test/mozilla/file_spacing_property_order.html
dom/animation/test/mozilla/test_spacing_property_order.html
dom/animation/test/style/file_animation-setting-spacing.html
dom/animation/test/style/test_animation-setting-spacing.html
--- a/dom/animation/test/chrome/test_animation_observers_sync.html
+++ b/dom/animation/test/chrome/test_animation_observers_sync.html
@@ -411,83 +411,16 @@ function runTest() {
 
     test(t => {
       var div = addDiv(t);
       var observer =
         setupSynchronousObserver(t,
                                  aOptions.subtree ? div.parentNode : div,
                                  aOptions.subtree);
 
-      var anim = div.animate([ { marginLeft: "0px" },
-                               { marginLeft: "-20px" },
-                               { marginLeft: "100px" },
-                               { marginLeft: "50px" } ],
-                             { duration: 100 * MS_PER_SEC });
-      assert_equals_records(observer.takeRecords(),
-        [{ added: [anim], changed: [], removed: [] }],
-        "records after animation is added");
-
-      anim.effect.spacing = "paced(margin-left)";
-      assert_equals_records(observer.takeRecords(),
-        [{ added: [], changed: [anim], removed: [] }],
-        "records after animation is changed");
-    }, "set_spacing");
-
-    test(t => {
-      var div = addDiv(t);
-      var observer =
-        setupSynchronousObserver(t,
-                                 aOptions.subtree ? div.parentNode : div,
-                                 aOptions.subtree);
-
-      var anim = div.animate([ { marginLeft: "0px" },
-                               { marginLeft: "-20px" },
-                               { marginLeft: "100px" },
-                               { marginLeft: "50px" } ],
-                             { duration: 100 * MS_PER_SEC,
-                               spacing: "paced(margin-left)" });
-      assert_equals_records(observer.takeRecords(),
-        [{ added: [anim], changed: [], removed: [] }],
-        "records after animation is added");
-
-      anim.effect.spacing = "paced(animation-duration)";
-      assert_equals_records(observer.takeRecords(),
-        [{ added: [], changed: [anim], removed: [] }],
-        "records after setting a non-animatable paced property");
-    }, "set_spacing_on_a_non-animatable_property");
-
-    test(t => {
-      var div = addDiv(t);
-      var observer =
-        setupSynchronousObserver(t,
-                                 aOptions.subtree ? div.parentNode : div,
-                                 aOptions.subtree);
-
-      var anim = div.animate([ { marginLeft: "0px" },
-                               { marginLeft: "-20px" },
-                               { marginLeft: "100px" },
-                               { marginLeft: "50px" } ],
-                             { duration: 100 * MS_PER_SEC,
-                               spacing: "paced(margin-left)" });
-      assert_equals_records(observer.takeRecords(),
-        [{ added: [anim], changed: [], removed: [] }],
-        "records after animation is added");
-
-      anim.effect.spacing = "paced(margin-left)";
-      assert_equals_records(observer.takeRecords(),
-        [], "no record after setting the same spacing");
-    }, "set_the_same_spacing");
-
-    test(t => {
-      var div = addDiv(t);
-      var observer =
-        setupSynchronousObserver(t,
-                                 aOptions.subtree ? div.parentNode : div,
-                                 aOptions.subtree);
-
       var anim = div.animate({ }, 100 * MS_PER_SEC);
       assert_equals_records(observer.takeRecords(),
         [{ added: [anim], changed: [], removed: [] }],
         "records after animation is added");
 
       anim.effect.composite = "add";
       assert_equals_records(observer.takeRecords(),
         [{ added: [], changed: [anim], removed: [] }],
deleted file mode 100644
--- a/dom/animation/test/crashtests/1290535-1.html
+++ /dev/null
@@ -1,20 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-  <title>Bug 1290535 - Sort paced subproperties of a shorthand property</title>
-<meta charset="UTF-8">
-<script>
-
-function test()
-{
-  var div = document.createElement('div');
-  document.documentElement.appendChild(div);
-  div.animate([ { borderRadius: "0", borderTopRightRadius: "0" },
-                { borderRadius: "50%" } ],
-              { spacing:"paced(border-radius)" });
-}
-
-</script>
-</head>
-<body onload="test();"></body>
-</html>
deleted file mode 100644
--- a/dom/animation/test/crashtests/1333418-1.html
+++ /dev/null
@@ -1,18 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<meta charset="UTF-8">
-<script>
-window.onload = function(){
-  let body = document.getElementsByTagName("body")[0];
-  let o = new KeyframeEffect(body, [
-    { "perspective": "none", "width": "auto" },
-    { "perspective": "172.17866832in", "width": "auto" },
-    { "perspective": "0" }],
-    { spacing:"paced(perspective)" }
-  );
-};
-</script>
-</head>
-<body></body>
-</html>
--- a/dom/animation/test/crashtests/crashtests.list
+++ b/dom/animation/test/crashtests/crashtests.list
@@ -5,27 +5,25 @@ pref(dom.animations-api.core.enabled,tru
 pref(dom.animations-api.core.enabled,true) load 1216842-3.html
 pref(dom.animations-api.core.enabled,true) load 1216842-4.html
 pref(dom.animations-api.core.enabled,true) load 1216842-5.html
 pref(dom.animations-api.core.enabled,true) load 1216842-6.html
 skip-if(webrender) pref(dom.animations-api.core.enabled,true) load 1272475-1.html # see bug 1367994
 pref(dom.animations-api.core.enabled,true) load 1272475-2.html
 pref(dom.animations-api.core.enabled,true) load 1278485-1.html
 pref(dom.animations-api.core.enabled,true) load 1277272-1.html
-pref(dom.animations-api.core.enabled,true) load 1290535-1.html
 pref(dom.animations-api.core.enabled,true) load 1304886-1.html
 pref(dom.animations-api.core.enabled,true) load 1322382-1.html
 pref(dom.animations-api.core.enabled,true) load 1322291-1.html
 pref(dom.animations-api.core.enabled,true) load 1322291-2.html
 pref(dom.animations-api.core.enabled,true) load 1323114-1.html
 pref(dom.animations-api.core.enabled,true) load 1323114-2.html
 pref(dom.animations-api.core.enabled,true) load 1324554-1.html
 pref(dom.animations-api.core.enabled,true) load 1325193-1.html
 pref(dom.animations-api.core.enabled,true) load 1330190-1.html
 pref(dom.animations-api.core.enabled,true) load 1330190-2.html
 pref(dom.animations-api.core.enabled,true) load 1330513-1.html
 pref(dom.animations-api.core.enabled,true) load 1333539-1.html
 pref(dom.animations-api.core.enabled,true) load 1333539-2.html
-pref(dom.animations-api.core.enabled,true) load 1333418-1.html
 pref(dom.animations-api.core.enabled,true) load 1334583-1.html
 pref(dom.animations-api.core.enabled,true) load 1335998-1.html
 pref(dom.animations-api.core.enabled,true) load 1343589-1.html
 pref(dom.animations-api.core.enabled,true) load 1359658-1.html
--- a/dom/animation/test/mochitest.ini
+++ b/dom/animation/test/mochitest.ini
@@ -42,25 +42,23 @@ support-files =
   document-timeline/file_document-timeline.html
   mozilla/file_cubic_bezier_limits.html
   mozilla/file_deferred_start.html
   mozilla/file_disabled_properties.html
   mozilla/file_disable_animations_api_core.html
   mozilla/file_discrete-animations.html
   mozilla/file_document-timeline-origin-time-range.html
   mozilla/file_hide_and_show.html
-  mozilla/file_spacing_property_order.html
   mozilla/file_transform_limits.html
   mozilla/file_transition_finish_on_compositor.html
   mozilla/file_underlying-discrete-value.html
   mozilla/file_set-easing.html
   style/file_animation-seeking-with-current-time.html
   style/file_animation-seeking-with-start-time.html
   style/file_animation-setting-effect.html
-  style/file_animation-setting-spacing.html
   style/file_composite.html
   style/file_missing-keyframe.html
   style/file_missing-keyframe-on-compositor.html
   ../../../layout/style/test/property_database.js
   testcommon.js
 
 [css-animations/test_animations-dynamic-changes.html]
 [css-animations/test_animation-cancel.html]
@@ -104,20 +102,18 @@ support-files =
 [mozilla/test_deferred_start.html]
 [mozilla/test_disable_animations_api_core.html]
 [mozilla/test_disabled_properties.html]
 [mozilla/test_discrete-animations.html]
 [mozilla/test_document-timeline-origin-time-range.html]
 [mozilla/test_hide_and_show.html]
 [mozilla/test_moz-prefixed-properties.html]
 [mozilla/test_set-easing.html]
-[mozilla/test_spacing_property_order.html]
 [mozilla/test_transform_limits.html]
 [mozilla/test_transition_finish_on_compositor.html]
 skip-if = toolkit == 'android'
 [mozilla/test_underlying-discrete-value.html]
 [style/test_animation-seeking-with-current-time.html]
 [style/test_animation-seeking-with-start-time.html]
 [style/test_animation-setting-effect.html]
-[style/test_animation-setting-spacing.html]
 [style/test_composite.html]
 [style/test_missing-keyframe.html]
 [style/test_missing-keyframe-on-compositor.html]
deleted file mode 100644
--- a/dom/animation/test/mozilla/file_spacing_property_order.html
+++ /dev/null
@@ -1,33 +0,0 @@
-<!doctype html>
-<meta charset=utf-8>
-<script src="../testcommon.js"></script>
-<body>
-<script>
-'use strict';
-
-test(function(t) {
-  var div = document.createElement('div');
-  document.documentElement.appendChild(div);
-  var anim = div.animate([ { borderRadius: "0", borderTopRightRadius: "10%" },
-                           { borderTopLeftRadius: "20%",
-                             borderTopRightRadius: "30%",
-                             borderBottomRightRadius: "40%",
-                             borderBottomLeftRadius: "50%" },
-                           { borderRadius: "50%" } ],
-                         { spacing:"paced(border-radius)" });
-
-  var frames = anim.effect.getKeyframes();
-  var dist = [ 0,
-               Math.sqrt(20 * 20 + (30 - 10) * (30 - 10) + 40 * 40 + 50 * 50),
-               Math.sqrt((50 - 20) * (50 - 20) + (50 - 30) * (50 - 30) +
-                         (50 - 40) * (50 - 40) + (50 - 50) * (50 - 50)) ];
-  var cumDist = [];
-  dist.reduce(function(prev, curr, i) { return cumDist[i] = prev + curr; }, 0);
-  assert_approx_equals(frames[1].computedOffset, cumDist[1] / cumDist[2],
-                       0.0001, 'frame offset');
-}, 'Test for the longhand components of the shorthand property surely sorted' );
-
-done();
-
-</script>
-</body>
deleted file mode 100644
--- a/dom/animation/test/mozilla/test_spacing_property_order.html
+++ /dev/null
@@ -1,14 +0,0 @@
-<!doctype html>
-<meta charset=utf-8>
-<script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
-<div id="log"></div>
-<script>
-'use strict';
-setup({explicit_done: true});
-SpecialPowers.pushPrefEnv(
-  { "set": [["dom.animations-api.core.enabled", true]]},
-  function() {
-    window.open("file_spacing_property_order.html");
-  });
-</script>
deleted file mode 100644
--- a/dom/animation/test/style/file_animation-setting-spacing.html
+++ /dev/null
@@ -1,111 +0,0 @@
-<!doctype html>
-<head>
-<meta charset=utf-8>
-<title>Tests for setting spacing by using KeyframeEffect.spacing</title>
-<script src='../testcommon.js'></script>
-</head>
-<body>
-<script>
-'use strict';
-
-function calculateInterpolation(pacedDistances, values, progress) {
-  if (progress == 0.0) {
-    return values[0];
-  } else if (progress == 1.0) {
-    return values[valus.length - 1];
-  }
-
-  const cumDist = pacedDistances.reduce( (prev, curr) => {
-    prev.push(prev.length == 0 ? curr : curr + prev[prev.length - 1]);
-    return prev;
-  }, []);
-
-  const last = cumDist[cumDist.length - 1];
-  const offsets = cumDist.map( (curr) => { return curr / last; } );
-
-  let idx = 0;
-  for (let i = 0; i < offsets.length - 1; ++i) {
-    if (progress >= offsets[i] && progress < offsets[i + 1]) {
-      idx = i;
-      break;
-    }
-  }
-
-  const ratio = (progress - offsets[idx]) / (offsets[idx + 1] - offsets[idx]);
-  return values[idx] + ratio * (values[idx + 1] - values[idx]) + 'px';
-}
-
-promise_test(function(t) {
-  var target = addDiv(t);
-  var anim = target.animate([ { marginLeft: '0px' },
-                              { marginLeft: '-20px' },
-                              { marginLeft: '100px' },
-                              { marginLeft: '50px' } ],
-                            100 * MS_PER_SEC);
-
-  return anim.ready.then(function() {
-    anim.currentTime = 50 * MS_PER_SEC;
-    assert_equals(getComputedStyle(target).marginLeft, '40px',
-                  'computed value before setting a new spacing');
-
-    var dist = [0, 20, 120, 50];
-    var marginLeftValues = [0, -20, 100, 50];
-    anim.effect.spacing = 'paced(margin-left)';
-    assert_equals(getComputedStyle(target).marginLeft,
-                  calculateInterpolation(dist, marginLeftValues, 0.5),
-                  'computed value after setting a new spacing');
-  });
-}, 'Test for setting spacing from distribute to paced');
-
-promise_test(function(t) {
-  var target = addDiv(t);
-  var anim = target.animate([ { marginLeft: '0px' },
-                              { marginLeft: '-20px' },
-                              { marginLeft: '100px' },
-                              { marginLeft: '50px' } ],
-                            { duration: 100 * MS_PER_SEC,
-                              spacing: 'paced(margin-left)' });
-
-  return anim.ready.then(function() {
-    var dist = [0, 20, 120, 50];
-    var marginLeftValues = [0, -20, 100, 50];
-    anim.currentTime = 50 * MS_PER_SEC;
-    assert_equals(getComputedStyle(target).marginLeft,
-                  calculateInterpolation(dist, marginLeftValues, 0.5),
-                  'computed value before setting a new spacing');
-
-    anim.effect.spacing = 'distribute';
-    assert_equals(getComputedStyle(target).marginLeft, '40px',
-                  'computed value after setting a new spacing');
-  });
-}, 'Test for setting spacing from paced to distribute');
-
-promise_test(function(t) {
-  var target = addDiv(t);
-  var anim =
-    target.animate([ { marginLeft: '0px', borderRadius: '0%' },
-                     { marginLeft: '-20px', borderRadius: '50%' },
-                     { marginLeft: '100px', borderRadius: '25%' },
-                     { marginLeft: '50px', borderRadius: '100%' } ],
-                   { duration: 100 * MS_PER_SEC,
-                     spacing: 'paced(margin-left)' });
-
-  return anim.ready.then(function() {
-    var dist = [0, 20, 120, 50];
-    var marginLeftValues = [0, -20, 100, 50];
-    anim.currentTime = 50 * MS_PER_SEC;
-    assert_equals(getComputedStyle(target).marginLeft,
-                  calculateInterpolation(dist, marginLeftValues, 0.5),
-                  'computed value before setting a new spacing');
-
-    dist = [0, 50, 25, 75];
-    anim.effect.spacing = 'paced(border-radius)';
-    assert_equals(getComputedStyle(target).marginLeft,
-                  calculateInterpolation(dist, marginLeftValues, 0.5),
-                  'computed value after setting a new spacing');
-  });
-}, 'Test for setting spacing from paced to a different paced');
-
-done();
-</script>
-</body>
deleted file mode 100644
--- a/dom/animation/test/style/test_animation-setting-spacing.html
+++ /dev/null
@@ -1,14 +0,0 @@
-<!doctype html>
-<meta charset=utf-8>
-<script src='/resources/testharness.js'></script>
-<script src='/resources/testharnessreport.js'></script>
-<div id='log'></div>
-<script>
-'use strict';
-setup({explicit_done: true});
-SpecialPowers.pushPrefEnv(
-  { 'set': [['dom.animations-api.core.enabled', true]]},
-  function() {
-    window.open('file_animation-setting-spacing.html');
-  });
-</script>