Bug 1372768 - Remove unused opus floating point code. r?kinetik draft
authorRalph Giles <giles@mozilla.com>
Tue, 13 Jun 2017 17:30:21 -0700
changeset 593691 ccb6a56e3a70531540bc969ab5a24009d144d274
parent 593476 980f99bd7aac2b105198f10343f418bdca04ed06
child 633179 0f2fa5969ab9a85986ad7ef8d045c268d489a623
push id63772
push userbmo:giles@thaumas.net
push dateWed, 14 Jun 2017 00:32:44 +0000
reviewerskinetik
bugs1372768, 1372622
milestone56.0a1
Bug 1372768 - Remove unused opus floating point code. r?kinetik We were including opus_sources_float even in fixed_point builds so webrtc could call the audio classifier. Now that that's been removed in bug 1372622, we can drop the extra sources. This applies only to Android arm builds. MozReview-Commit-ID: FiOxRrCGBYm
media/libopus/moz.build
--- a/media/libopus/moz.build
+++ b/media/libopus/moz.build
@@ -80,18 +80,16 @@ if CONFIG['MOZ_SAMPLE_TYPE_FLOAT32']:
     ]
     UNIFIED_SOURCES += silk_sources_float
     UNIFIED_SOURCES += opus_sources_float
 else:
     LOCAL_INCLUDES += [
         'silk/fixed',
     ]
     UNIFIED_SOURCES += silk_sources_fixed
-# for webrtc
-    UNIFIED_SOURCES += opus_sources_float
 
 if CONFIG['CPU_ARCH'] == 'arm' and CONFIG['GNU_AS']:
     SOURCES += celt_sources_arm
     SOURCES += [
         '!celt_pitch_xcorr_arm-gnu.s'
     ]
     # -Os is significantly slower, enable -O3 unless optimization is disabled
     if CONFIG['MOZ_OPTIMIZE']: