Bug 1372427 - add cyclomatic-complexity limit. r=mattn draft
authorJonathan Guillotte-Blouin <jguillotteblouin@mozilla.com>
Tue, 13 Jun 2017 15:56:31 -0700
changeset 597774 d4cfcb1cbe723d10bdad41514cad0346fd132de2
parent 597773 14aea8535afd9f071de74f67c13e848935b2a040
child 597775 855aabc8fa5c303fe73e754de00fde65d72f892a
push id65025
push userbmo:jguillotteblouin@mozilla.com
push dateTue, 20 Jun 2017 23:10:16 +0000
reviewersmattn
bugs1372427
milestone56.0a1
Bug 1372427 - add cyclomatic-complexity limit. r=mattn MozReview-Commit-ID: GRiJw8SBq9e
toolkit/components/satchel/.eslintrc.js
toolkit/components/satchel/test/test_form_autocomplete_with_list.html
toolkit/components/satchel/test/test_form_submission.html
--- a/toolkit/components/satchel/.eslintrc.js
+++ b/toolkit/components/satchel/.eslintrc.js
@@ -32,10 +32,13 @@ module.exports = {
       requireParamDescription: false,
       requireReturn: false,
       requireReturnDescription: false,
     }],
     "block-scoped-var": "error",
     "no-use-before-define": ["error", {
       functions: false,
     }],
+    complexity: ["error", {
+      max: 20,
+    }],
   },
 };
--- a/toolkit/components/satchel/test/test_form_autocomplete_with_list.html
+++ b/toolkit/components/satchel/test/test_form_autocomplete_with_list.html
@@ -38,16 +38,17 @@ Form History test: form field autocomple
     <option value="final"></option>
   </datalist>
 </div>
 
 <pre id="test">
 <script class="testbody" type="text/javascript">
 /* import-globals-from ../../../../testing/mochitest/tests/SimpleTest/EventUtils.js */
 /* import-globals-from satchel_common.js */
+/* eslint-disable complexity */
 
 /** Test for Form History autocomplete **/
 
 var input = $_(1, "field1");
 const shiftModifier = Components.interfaces.nsIDOMEvent.SHIFT_MASK;
 
 function setupFormHistory(aCallback) {
   updateFormHistory([
--- a/toolkit/components/satchel/test/test_form_submission.html
+++ b/toolkit/components/satchel/test/test_form_submission.html
@@ -237,16 +237,18 @@
     <input type="text" name="test9">
     <button type="submit">Submit</button>
   </form>
 
 </div>
 <pre id="test">
 <script class="testbody" type="text/javascript">
 /* import-globals-from satchel_common.js */
+/* eslint-disable complexity */
+
 var numSubmittedForms = 0;
 
 var ccNumbers = {
   valid15: [
     "930771457288760", "474915027480942",
     "924894781317325", "714816113937185",
     "790466087343106", "474320195408363",
     "219211148122351", "633038472250799",