Bug 1369908 - Schedule linux64-ccov, and linux64-jsdcov on all mozilla-central pushes. r?jmaher draft
authorGreg Mierzwinski <gmierz2@outlook.com>
Tue, 13 Jun 2017 13:04:08 -0400
changeset 593483 545f1b972cc2f73748f8e545f6911920ff7e3202
parent 592668 2a63a6c35033b5cbc6c98cabc7657c7290284691
child 633124 998750d51706eb1903325303229312a3557861c0
push id63711
push userbmo:gmierz2@outlook.com
push dateTue, 13 Jun 2017 18:07:59 +0000
reviewersjmaher
bugs1369908
milestone56.0a1
Bug 1369908 - Schedule linux64-ccov, and linux64-jsdcov on all mozilla-central pushes. r?jmaher This patch removes the nightly code coverage run in favor of simply running the two code coverage builds on every single push to mozilla-central for a more granular view of code coverage over time. MozReview-Commit-ID: E4Xp5bB19m9
.cron.yml
taskcluster/taskgraph/target_tasks.py
taskcluster/taskgraph/transforms/tests.py
--- a/.cron.yml
+++ b/.cron.yml
@@ -60,18 +60,8 @@ jobs:
           type: decision-task
           treeherder-symbol: Vg
           target-tasks-method: mochitest_valgrind
       run-on-projects:
           - mozilla-central
       when:
           - {hour: 16, minute: 0}
           - {hour: 4, minute: 0}
-
-    - name: nightly-code-coverage
-      job:
-          type: decision-task
-          treeherder-symbol: Nc
-          target-tasks-method: nightly_code_coverage
-      run-on-projects:
-          - mozilla-central
-      when:
-          - {hour: 18, minute: 0}
--- a/taskcluster/taskgraph/target_tasks.py
+++ b/taskcluster/taskgraph/target_tasks.py
@@ -184,27 +184,16 @@ def target_tasks_valgrind(full_task_grap
         if task.attributes.get('unittest_suite', '').startswith('mochitest') and \
            task.attributes.get('unittest_flavor', '').startswith('valgrind-plain'):
             return True
         return False
 
     return [l for l, t in full_task_graph.tasks.iteritems() if filter(t)]
 
 
-@_target_task('nightly_code_coverage')
-def target_tasks_code_coverage(full_task_graph, parameters):
-    """Target tasks that generate coverage data."""
-    def filter(task):
-        platform = task.attributes.get('test_platform', '').split('/')[0]
-        if platform not in ('linux64-ccov', 'linux64-jsdcov'):
-            return False
-        return True
-    return [l for l, t in full_task_graph.tasks.iteritems() if filter(t)]
-
-
 @_target_task('nightly_fennec')
 def target_tasks_nightly_fennec(full_task_graph, parameters):
     """Select the set of tasks required for a nightly build of fennec. The
     nightly build process involves a pipeline of builds, signing,
     and, eventually, uploading the tasks to balrog."""
     def filter(task):
         platform = task.attributes.get('build_platform')
         if platform in ('android-aarch64-nightly',
--- a/taskcluster/taskgraph/transforms/tests.py
+++ b/taskcluster/taskgraph/transforms/tests.py
@@ -507,19 +507,19 @@ def handle_keyed_by(config, tests):
 @transforms.add
 def enable_code_coverage(config, tests):
     """Enable code coverage for the linux64-ccov/opt & linux64-jsdcov/opt build-platforms"""
     for test in tests:
         if test['build-platform'] == 'linux64-ccov/opt':
             test['mozharness'].setdefault('extra-options', []).append('--code-coverage')
             test['when'] = {}
             test['instance-size'] = 'xlarge'
-            test['run-on-projects'] = []
+            test['run-on-projects'] = ['mozilla-central']
         elif test['build-platform'] == 'linux64-jsdcov/opt':
-            test['run-on-projects'] = []
+            test['run-on-projects'] = ['mozilla-central']
         yield test
 
 
 @transforms.add
 def handle_run_on_projects(config, tests):
     """Handle translating `built-projects` appropriately"""
     for test in tests:
         if test['run-on-projects'] == 'built-projects':