Bug 1372495 - Define dialog size to fix browser_manageProfilesDialog test failure. r=lchang draft
authorScott Wu <scottcwwu@gmail.com>
Tue, 13 Jun 2017 15:38:01 +0800
changeset 593102 dcec41736c445b9153a9748b31b4ec9384ad4c9b
parent 592979 2a3a253806d129c0bb6f2b76bf75630457a24492
child 633027 62ceeed8e2e1f0491ef0fa67104498cce5c8affd
push id63605
push userbmo:scwwu@mozilla.com
push dateTue, 13 Jun 2017 07:40:54 +0000
reviewerslchang
bugs1372495
milestone56.0a1
Bug 1372495 - Define dialog size to fix browser_manageProfilesDialog test failure. r=lchang MozReview-Commit-ID: H8zZYyh4iTJ
browser/extensions/formautofill/test/browser/browser_manageProfilesDialog.js
--- a/browser/extensions/formautofill/test/browser/browser_manageProfilesDialog.js
+++ b/browser/extensions/formautofill/test/browser/browser_manageProfilesDialog.js
@@ -2,16 +2,18 @@
 
 const TEST_SELECTORS = {
   selAddresses: "#profiles",
   btnRemove: "#remove",
   btnAdd: "#add",
   btnEdit: "#edit",
 };
 
+const DIALOG_SIZE = "width=600,height=400";
+
 function waitForAddresses() {
   return new Promise(resolve => {
     Services.cpmm.addMessageListener("FormAutofill:Addresses", function getResult(result) {
       Services.cpmm.removeMessageListener("FormAutofill:Addresses", getResult);
       // Wait for the next tick for elements to get rendered.
       SimpleTest.executeSoon(resolve.bind(null, result.data));
     });
   });
@@ -40,17 +42,17 @@ add_task(async function test_manageProfi
   });
 });
 
 add_task(async function test_removingSingleAndMultipleProfiles() {
   await saveAddress(TEST_ADDRESS_1);
   await saveAddress(TEST_ADDRESS_2);
   await saveAddress(TEST_ADDRESS_3);
 
-  let win = window.openDialog(MANAGE_PROFILES_DIALOG_URL);
+  let win = window.openDialog(MANAGE_PROFILES_DIALOG_URL, null, DIALOG_SIZE);
   await waitForAddresses();
 
   let selAddresses = win.document.querySelector(TEST_SELECTORS.selAddresses);
   let btnRemove = win.document.querySelector(TEST_SELECTORS.btnRemove);
   let btnEdit = win.document.querySelector(TEST_SELECTORS.btnEdit);
 
   is(selAddresses.length, 3, "Three addresses");
 
@@ -69,17 +71,17 @@ add_task(async function test_removingSin
   EventUtils.synthesizeMouseAtCenter(btnRemove, {}, win);
   await waitForAddresses();
   is(selAddresses.length, 0, "All addresses are removed");
 
   win.close();
 });
 
 add_task(async function test_profilesDialogWatchesStorageChanges() {
-  let win = window.openDialog(MANAGE_PROFILES_DIALOG_URL);
+  let win = window.openDialog(MANAGE_PROFILES_DIALOG_URL, null, DIALOG_SIZE);
   await waitForAddresses();
 
   let selAddresses = win.document.querySelector(TEST_SELECTORS.selAddresses);
 
   await saveAddress(TEST_ADDRESS_1);
   let addresses = await waitForAddresses();
   is(selAddresses.length, 1, "One address is shown");