Bug 1371701 - Fixed sandboxing tests to reflect that we're enabling file content process for all channels draft
authorAlex Gaynor <agaynor@mozilla.com>
Fri, 09 Jun 2017 11:24:07 -0400
changeset 591764 cc4d7820c0392f8662a2c1ab1b18e92812532050
parent 591727 eca8d0ea03af1d2424550a037f714f14c0f7b1be
child 632622 5bb2153c7d8d16e0dc6c81ae8a6b08e25d9e46ee
push id63172
push userbmo:agaynor@mozilla.com
push dateFri, 09 Jun 2017 15:27:04 +0000
bugs1371701
milestone55.0a1
Bug 1371701 - Fixed sandboxing tests to reflect that we're enabling file content process for all channels MozReview-Commit-ID: ICXZjEU2n6L
security/sandbox/test/browser_content_sandbox_fs.js
--- a/security/sandbox/test/browser_content_sandbox_fs.js
+++ b/security/sandbox/test/browser_content_sandbox_fs.js
@@ -218,30 +218,20 @@ function* createTempFile() {
   ok(fileDeleted == true, "deleting a file in content temp is permitted");
 }
 
 // Test reading files and dirs from web and file content processes.
 function* testFileAccess() {
   // for tests that run in a web content process
   let webBrowser = gBrowser.selectedBrowser;
 
-  // For now, we'll only test file access from the file content process if
-  // the file content process is enabled. Once the file content process is
-  // ready to ride the trains, this test should be changed to always test
-  // file content process access. We use todo() to cause failures
-  // if the file process is enabled on a non-Nightly release so that we'll
-  // know to update this test to always run the tests. i.e., we'll want to
-  // catch bugs that accidentally disable file content process.
+  // Ensure that the file content process is enabled.
   let fileContentProcessEnabled =
     prefs.getBoolPref("browser.tabs.remote.separateFileUriProcess");
-  if (isNightly()) {
-    ok(fileContentProcessEnabled, "separate file content process is enabled");
-  } else {
-    todo(fileContentProcessEnabled, "separate file content process is enabled");
-  }
+  ok(fileContentProcessEnabled, "separate file content process is enabled");
 
   // for tests that run in a file content process
   let fileBrowser = undefined;
   if (fileContentProcessEnabled) {
     // open a tab in a file content process
     gBrowser.selectedTab =
       BrowserTestUtils.addTab(gBrowser, "about:blank", {preferredRemoteType: "file"});
     // get the browser for the file content process tab