Bug 1368145 - Change 'All Devices' to 'Send to All Devices' with its property name r=eoger
MozReview-Commit-ID: 5g6IuuV51P6
--- a/browser/base/content/browser-sync.js
+++ b/browser/base/content/browser-sync.js
@@ -317,22 +317,22 @@ var gSync = {
fragment.appendChild(targetDevice);
}
const clients = this.remoteClients;
for (let client of clients) {
addTargetDevice(client.id, client.name, client.type);
}
- // "All devices" menu item
+ // "Send to All Devices" menu item
if (clients.length > 1) {
const separator = createDeviceNodeFn();
separator.classList.add("sync-menuitem");
fragment.appendChild(separator);
- const allDevicesLabel = this.fxaStrings.GetStringFromName("sendTabToAllDevices.menuitem");
+ const allDevicesLabel = this.fxaStrings.GetStringFromName("sendToAllDevices.menuitem");
addTargetDevice("", allDevicesLabel, "");
}
devicesPopup.appendChild(fragment);
},
isSendableURI(aURISpec) {
if (!aURISpec) {
--- a/browser/base/content/test/general/browser_visibleTabs_contextMenu.js
+++ b/browser/base/content/test/general/browser_visibleTabs_contextMenu.js
@@ -25,17 +25,17 @@ add_task(async function test() {
const oldGetter = setupRemoteClientsFixture(remoteClientsFixture);
await updateTabContextMenu(origTab, async function() {
await openMenuItemSubmenu("context_sendTabToDevice");
});
is(document.getElementById("context_sendTabToDevice").hidden, false, "Send tab to device is shown");
let targets = document.getElementById("context_sendTabToDevicePopupMenu").childNodes;
is(targets[0].getAttribute("label"), "Foo", "Foo target is present");
is(targets[1].getAttribute("label"), "Bar", "Bar target is present");
- is(targets[3].getAttribute("label"), "All Devices", "All Devices target is present");
+ is(targets[3].getAttribute("label"), "Send to All Devices", "Send to All Devices target is present");
gSync.isSendableURI = () => false;
updateTabContextMenu(origTab);
is(document.getElementById("context_sendTabToDevice").hidden, true, "Send tab to device is hidden");
restoreRemoteClients(oldGetter);
gSync.isSendableURI = origIsSendableURI;
}
// Hide the original tab.
--- a/browser/base/content/test/urlbar/browser_page_action_menu.js
+++ b/browser/base/content/test/urlbar/browser_page_action_menu.js
@@ -272,17 +272,17 @@ add_task(async function sendToDevice_dev
label: client.name,
clientType: client.type,
},
});
}
expectedItems.push(
null,
{
- label: "All Devices",
+ label: "Send to All Devices",
}
);
checkSendToDeviceItems(expectedItems);
// Done, hide the panel.
let hiddenPromise = promisePanelHidden();
gPanel.hidePopup();
await hiddenPromise;
--- a/browser/locales/en-US/chrome/browser/accounts.properties
+++ b/browser/locales/en-US/chrome/browser/accounts.properties
@@ -30,19 +30,19 @@ syncStartNotification.title = Sync enabl
# %S is brandShortName
syncStartNotification.body2 = %S will begin syncing momentarily.
# LOCALIZATION NOTE (deviceDisconnectedNotification.title, deviceDisconnectedNotification.body)
# These strings are used in a notification shown after Sync was disconnected remotely.
deviceDisconnectedNotification.title = Sync disconnected
deviceDisconnectedNotification.body = This computer has been successfully disconnected from Firefox Sync.
-# LOCALIZATION NOTE (sendTabToAllDevices.menuitem)
-# Displayed in the Send Tabs context menu when right clicking a tab, a page or a link.
-sendTabToAllDevices.menuitem = All Devices
+# LOCALIZATION NOTE (sendToAllDevices.menuitem)
+# Displayed in the Send Tab/Page/Link to Device context menu when right clicking a tab, a page or a link.
+sendToAllDevices.menuitem = Send to All Devices
# LOCALIZATION NOTE (tabArrivingNotification.title, tabArrivingNotificationWithDevice.title,
# tabsArrivingNotification.title, unnamedTabsArrivingNotification2.body,
# unnamedTabsArrivingNotificationMultiple2.body, unnamedTabsArrivingNotificationNoDevice.body)
# These strings are used in a notification shown when we're opening tab(s) another device sent us to display.
# LOCALIZATION NOTE (tabArrivingNotification.title, tabArrivingNotificationWithDevice.title)
# The body for these is the URL of the tab recieved