Bug 1370762 - Null check GetSelection() before calling Stringify(). r?mtseng draft
authorTing-Yu Lin <tlin@mozilla.com>
Thu, 08 Jun 2017 12:49:05 +0800
changeset 590840 17e2628ae67efd2929926fa4d8d2a23ec452d15f
parent 590795 7efda263a842e60cd0cc00b3c4a7058c65590702
child 632321 aabcb67e0f977ab0ed1a62af67dcd29d4b8a5496
push id62845
push userbmo:tlin@mozilla.com
push dateThu, 08 Jun 2017 06:01:36 +0000
reviewersmtseng
bugs1370762
milestone55.0a1
Bug 1370762 - Null check GetSelection() before calling Stringify(). r?mtseng MozReview-Commit-ID: 9sNaXwzbqUw
layout/base/AccessibleCaretManager.cpp
--- a/layout/base/AccessibleCaretManager.cpp
+++ b/layout/base/AccessibleCaretManager.cpp
@@ -801,17 +801,20 @@ AccessibleCaretManager::GetFrameSelectio
     return mPresShell->FrameSelection();
   }
 }
 
 nsAutoString
 AccessibleCaretManager::StringifiedSelection() const
 {
   nsAutoString str;
-  GetSelection()->Stringify(str);
+  Selection* selection = GetSelection();
+  if (selection) {
+    selection->Stringify(str);
+  }
   return str;
 }
 
 Element*
 AccessibleCaretManager::GetEditingHostForFrame(nsIFrame* aFrame) const
 {
   if (!aFrame) {
     return nullptr;