Bug 1370899 - mock_runner.driverclass should return mock_marionette; r?whimboo draft
authorMaja Frydrychowicz <mjzffr@gmail.com>
Wed, 07 Jun 2017 10:32:04 -0400
changeset 592010 e071dd9a173dd7a7d6da4f4883060636b1778493
parent 592000 d0e38542a05b17dd87586281b5d324112d38f6ca
child 632697 4c58c68a5340cae015c5d0d1011ec0193ade404f
push id63255
push userbmo:mjzffr@gmail.com
push dateFri, 09 Jun 2017 21:30:45 +0000
reviewerswhimboo
bugs1370899
milestone55.0a1
Bug 1370899 - mock_runner.driverclass should return mock_marionette; r?whimboo Previously, mock_runner.driverclass() returned a plain Mock object. MozReview-Commit-ID: 1RMQhud4BJD
testing/marionette/harness/marionette_harness/tests/harness_unit/conftest.py
testing/marionette/harness/marionette_harness/tests/harness_unit/test_marionette_runner.py
--- a/testing/marionette/harness/marionette_harness/tests/harness_unit/conftest.py
+++ b/testing/marionette/harness/marionette_harness/tests/harness_unit/conftest.py
@@ -87,14 +87,14 @@ def mock_httpd(request):
     """ Mock httpd instance """
     httpd = MagicMock(spec=FixtureServer)
     return httpd
 
 
 @pytest.fixture
 def mock_marionette(request):
     """ Mock marionette instance """
-    marionette_class = MagicMock(spec=Marionette)
+    marionette = MagicMock(spec=Marionette())
     if 'has_crashed' in request.funcargnames:
-        marionette_class.check_for_crash.return_value = request.getfuncargvalue(
+        marionette.check_for_crash.return_value = request.getfuncargvalue(
             'has_crashed'
         )
-    return marionette_class
+    return marionette
--- a/testing/marionette/harness/marionette_harness/tests/harness_unit/test_marionette_runner.py
+++ b/testing/marionette/harness/marionette_harness/tests/harness_unit/test_marionette_runner.py
@@ -20,17 +20,17 @@ def runner(mach_parsed_kwargs):
 
 @pytest.fixture
 def mock_runner(runner, mock_marionette, monkeypatch):
     """
     MarionetteTestRunner instance with mocked-out
     self.marionette and other properties,
     to enable testing runner.run_tests().
     """
-    runner.driverclass = mock_marionette
+    runner.driverclass = Mock(return_value=mock_marionette)
     for attr in ['run_test_set', '_capabilities']:
         setattr(runner, attr, Mock())
     runner._appName = 'fake_app'
     # simulate that browser runs with e10s by default
     runner._appinfo = {'browserTabsRemoteAutostart': True}
     monkeypatch.setattr('marionette_harness.runner.base.mozversion', Mock())
     return runner