Bug 1366755 - devtools.panels.create should set invertIconForLightTheme to false by default. draft
authorLuca Greco <lgreco@mozilla.com>
Wed, 07 Jun 2017 16:34:56 +0200
changeset 590287 08db7fd9c912a1a12c1dad7dca615d46c4160386
parent 589544 4dd1d17ba22660b8f5869a707f2e4e9f9dd5be5b
child 632168 628004809fd8adb9a8c7b4a19461b1756a95c7e1
push id62678
push userluca.greco@alcacoop.it
push dateWed, 07 Jun 2017 14:43:15 +0000
bugs1366755
milestone55.0a1
Bug 1366755 - devtools.panels.create should set invertIconForLightTheme to false by default. MozReview-Commit-ID: 1bn3cMngoql
browser/components/extensions/ext-devtools-panels.js
browser/components/extensions/test/browser/browser_ext_devtools_panel.js
--- a/browser/components/extensions/ext-devtools-panels.js
+++ b/browser/components/extensions/ext-devtools-panels.js
@@ -77,17 +77,17 @@ class ParentDevToolsPanel {
     const extensionName = this.context.extension.name;
 
     this.toolbox.addAdditionalTool({
       id: this.id,
       url: "about:blank",
       icon: icon,
       label: title,
       tooltip: `DevTools Panel added by "${extensionName}" add-on.`,
-      invertIconForLightTheme: true,
+      invertIconForLightTheme: false,
       visibilityswitch:  `devtools.webext-${this.id}.enabled`,
       isTargetSupported: target => target.isLocalTab,
       build: (window, toolbox) => {
         if (toolbox !== this.toolbox) {
           throw new Error("Unexpected toolbox received on addAdditionalTool build property");
         }
 
         const destroy = this.buildPanel(window, toolbox);
--- a/browser/components/extensions/test/browser/browser_ext_devtools_panel.js
+++ b/browser/components/extensions/test/browser/browser_ext_devtools_panel.js
@@ -207,17 +207,21 @@ add_task(async function test_devtools_pa
 
   const toolboxAdditionalTools = toolbox.getAdditionalTools();
 
   is(toolboxAdditionalTools.length, 1,
      "Got the expected number of toolbox specific panel registered.");
 
   await testThemeSwitching(extension);
 
-  const panelId = toolboxAdditionalTools[0].id;
+  const panelDef = toolboxAdditionalTools[0];
+  const panelId = panelDef.id;
+
+  is(panelDef.invertIconForLightTheme, false,
+     "devtools.panel.create set invertIconForLightTheme to false by default");
 
   await gDevTools.showToolbox(target, panelId);
   const {devtoolsPageTabId} = await extension.awaitMessage("devtools_panel_shown");
   const devtoolsPanelTabId = await extension.awaitMessage("devtools_panel_inspectedWindow_tabId");
   is(devtoolsPanelTabId, devtoolsPageTabId,
      "Got the same devtools.inspectedWindow.tabId from devtools page and panel");
   is(await extension.awaitMessage("initial_theme_panel"),
     "light",