Bug 1370539 - Fix logic error around skipping package metrics; r?nalexander
b227363d66bb added a config item and code for disabling package
metrics, which don't work everywhere.
The previous logic was faulty.
MozReview-Commit-ID: BGxWgmWxXyH
--- a/testing/mozharness/mozharness/mozilla/building/buildbase.py
+++ b/testing/mozharness/mozharness/mozilla/building/buildbase.py
@@ -2028,17 +2028,17 @@ or run without that action (ie: --no-{ac
perfherder_data = {
"framework": {
"name": "build_metrics"
},
"suites": [],
}
- if not c.get('debug_build') or c.get('disable_package_metrics'):
+ if not c.get('debug_build') and not c.get('disable_package_metrics'):
perfherder_data['suites'].extend(self._get_package_metrics())
# Extract compiler warnings count.
warnings = self.get_output_from_command(
command=[sys.executable, 'mach', 'warnings-list'],
cwd=self.query_abs_dirs()['abs_src_dir'],
env=self.query_build_env(),
# No need to pollute the log.