Bug 1354463 - Set fails-if for opaque layer check fail. r=kats draft
authorMorris Tseng <mtseng@mozilla.com>
Tue, 06 Jun 2017 11:37:49 +0800
changeset 590121 dfabd5785dce81315d1c3ebcb27d20dad0e7f62c
parent 590120 8ad56bdcd66dc127c4b1b2bc662da4c2b539b9f3
child 590122 c9ff24951c54376933f4c78a623e37f34a0c4e29
push id62601
push userbmo:mtseng@mozilla.com
push dateWed, 07 Jun 2017 06:57:19 +0000
reviewerskats
bugs1354463
milestone55.0a1
Bug 1354463 - Set fails-if for opaque layer check fail. r=kats This is because in original gecko, canvas background color will merge to painted layer with other display items. When advanced canvas background color is enabled, the "other display items" won't be merged with canvas background color. Which means the layers that are generated by those display items may not be opaque. So set fails-if to those tests. MozReview-Commit-ID: 1WbMU8pGtTC
layout/reftests/css-animations/reftest.list
layout/reftests/layers/reftest.list
layout/reftests/reftest-sanity/reftest.list
--- a/layout/reftests/css-animations/reftest.list
+++ b/layout/reftests/css-animations/reftest.list
@@ -33,17 +33,17 @@ test-pref(layers.offmainthreadcompositio
 fails-if(webrender) == stacking-context-transform-none-animation-with-preserve-3d.html stacking-context-animation-ref.html
 == stacking-context-transform-none-with-fill-backwards.html stacking-context-animation-ref.html
 == stacking-context-transform-none-with-fill-forwards.html stacking-context-animation-ref.html
 == stacking-context-opacity-1-in-delay.html stacking-context-animation-ref.html
 == stacking-context-opacity-removing-important-in-delay.html stacking-context-animation-ref.html
 == stacking-context-transform-none-in-delay.html stacking-context-animation-ref.html
 == stacking-context-transform-removing-important-in-delay.html stacking-context-animation-ref.html
 fails == background-position-in-delay.html background-position-ref.html # This test fails the reftest-opaque-layer check since animating background-position currently creates an active layer from its delay phse, and reftest-opaque-layer only handles items assigned to PaintedLayers.
-== background-position-after-finish.html background-position-ref.html
+fails-if(webrender) == background-position-after-finish.html background-position-ref.html
 fails == background-position-running.html background-position-ref.html # This test fails the reftest-opaque-layer check since animating background-position currently creates an active layer, and reftest-opaque-layer only handles items assigned to PaintedLayers.
 fails == background-position-important.html background-position-ref.html # This test fails the reftest-opaque-layer check since animating background-position overridden by a non-animated !important style also creates an active layer, and reftest-opaque-layer only handles items that are assigned to PaintedLayers.
 
 == mask-position-after-finish-1a.html mask-anim-ref.html
 == mask-position-after-finish-1b.html mask-anim-ref.html
 == mask-position-in-delay-1a.html mask-anim-ref.html
 == mask-position-in-delay-1b.html mask-anim-ref.html
 == mask-size-after-finish-1a.html mask-anim-ref.html
--- a/layout/reftests/layers/reftest.list
+++ b/layout/reftests/layers/reftest.list
@@ -1,16 +1,16 @@
 == move-to-background-1.html move-to-background-1-ref.html
 fuzzy-if(cocoaWidget,2,6) random-if(Android) == component-alpha-exit-1.html component-alpha-exit-1-ref.html # bug 760275
-!= pull-background-1.html about:blank
-random-if(styloVsGecko) != pull-background-2.html about:blank
+fails-if(webrender) != pull-background-1.html about:blank
+fails-if(webrender) random-if(styloVsGecko) != pull-background-2.html about:blank
 fails-if(webrender) != pull-background-3.html about:blank
 fails-if(webrender) != pull-background-4.html about:blank
-fuzzy-if(styloVsGecko,1,1) != pull-background-5.html about:blank
-!= pull-background-6.html about:blank
+fails-if(webrender) fuzzy-if(styloVsGecko,1,1) != pull-background-5.html about:blank
+fails-if(webrender) != pull-background-6.html about:blank
 # The animated-position tests are disabled for intermittent failures / passes, bug 1150941
 skip != pull-background-animated-position-1.html about:blank # Fails with event regions
 skip != pull-background-animated-position-2.html about:blank
 skip != pull-background-animated-position-3.html about:blank # Fails because PaintedLayer item assignment doesn't recognize overflow:hidden clips
 skip != pull-background-animated-position-4.html about:blank # Fails because PaintedLayer item assignment and background pulling don't recognize overflow:hidden clips
 skip != pull-background-animated-position-5.html about:blank # Fails because ownLayer bounds don't anticipate changes of animated contents, but doesn't fail with event regions
 skip-if(!asyncPan) != pull-background-displayport-1.html about:blank
 skip-if(!asyncPan) random-if(styloVsGecko) != pull-background-displayport-2.html about:blank
--- a/layout/reftests/reftest-sanity/reftest.list
+++ b/layout/reftests/reftest-sanity/reftest.list
@@ -175,32 +175,32 @@ skip-if(!asyncPan||!browserIsRemote) == 
 default-preferences pref(layers.low-precision-buffer,false)
 skip-if(!asyncPan||!browserIsRemote) != async-scroll-1b.html async-scroll-1-ref.html
 default-preferences
 
 skip-if(!Android) pref(apz.allow_zooming,true) != async-zoom-1.html async-zoom-1-ref.html
 fuzzy(112,800) skip-if(!Android) pref(apz.allow_zooming,true) == async-zoom-2.html async-zoom-2-ref.html
 
 # reftest-opaque-layer
-== reftest-opaque-layer-pass.html reftest-opaque-layer-pass.html
-!= reftest-opaque-layer-pass.html about:blank
-!= about:blank reftest-opaque-layer-pass.html
+fails-if(webrender) == reftest-opaque-layer-pass.html reftest-opaque-layer-pass.html
+fails-if(webrender) != reftest-opaque-layer-pass.html about:blank
+fails-if(webrender) != about:blank reftest-opaque-layer-pass.html
 fails == reftest-opaque-layer-fail.html reftest-opaque-layer-fail.html
 
 # If reftest-opaque-layer fails (no matter whether it fails in the test or in the reference),
 # it shouldn't matter whether the test matches the reference.
 fails != reftest-opaque-layer-fail.html reftest-opaque-layer-fail.html
 fails == reftest-opaque-layer-fail.html about:blank
 fails-if(!styloVsGecko) == about:blank reftest-opaque-layer-fail.html
 fails != reftest-opaque-layer-fail.html about:blank
 fails-if(!styloVsGecko) != about:blank reftest-opaque-layer-fail.html
 
 # reftest-opaque-layer and reftest-wait
-== reftest-opaque-layer-wait-pass.html reftest-opaque-layer-pass.html
-!= reftest-opaque-layer-wait-pass.html about:blank
+fails-if(webrender) == reftest-opaque-layer-wait-pass.html reftest-opaque-layer-pass.html
+fails-if(webrender) != reftest-opaque-layer-wait-pass.html about:blank
 fails fails-if(styloVsGecko) == reftest-opaque-layer-wait-fail.html reftest-opaque-layer-fail.html
 fails-if(!styloVsGecko) fails-if(styloVsGecko) != reftest-opaque-layer-wait-fail.html about:blank
 
 # reftest-assigned-layer
 != reftest-assigned-layer-pass.html about:blank
 fails-if(!styloVsGecko) fails-if(styloVsGecko) != reftest-assigned-layer-fail-1.html about:blank
 fails-if(!styloVsGecko) fails-if(styloVsGecko) != reftest-assigned-layer-fail-2.html about:blank
 fails-if(!styloVsGecko) fails-if(styloVsGecko) != reftest-assigned-layer-fail-3.html about:blank