Bug 1370121 - Catch exceptions when destroying GeckoSurfaceTexture r=jchen draft
authorJames Willcox <snorp@snorp.net>
Mon, 05 Jun 2017 14:47:11 -0500
changeset 589186 e78361a5651b9e96db82f5ab2fb4aeb90e0baf9d
parent 589171 9611e13fccf62d0f97a4d8ec7e45c5423d5dcaa2
child 589717 3debe789646372c2f197d202d479bc18d94af4d5
push id62272
push userbmo:snorp@snorp.net
push dateMon, 05 Jun 2017 19:48:14 +0000
reviewersjchen
bugs1370121
milestone55.0a1
Bug 1370121 - Catch exceptions when destroying GeckoSurfaceTexture r=jchen MozReview-Commit-ID: KDoj9s0ebhY
mobile/android/geckoview/src/main/java/org/mozilla/gecko/gfx/GeckoSurfaceTexture.java
--- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/gfx/GeckoSurfaceTexture.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/gfx/GeckoSurfaceTexture.java
@@ -102,17 +102,22 @@ public final class GeckoSurfaceTexture e
         if (mUseCount == 0) {
             synchronized (sSurfaceTextures) {
                 sSurfaceTextures.remove(mHandle);
             }
 
             setListener(null);
 
             if (Versions.feature16Plus) {
-                detachFromGLContext();
+                try {
+                    detachFromGLContext();
+                } catch (Exception e) {
+                    // This can throw if the EGL context is not current
+                    // but we can't do anything about that now.
+                }
             }
 
             release();
         }
     }
 
     public static GeckoSurfaceTexture acquire(boolean singleBufferMode) {
         if (singleBufferMode && !isSingleBufferSupported()) {