Bug 1369871: Add "const" keyword to a long* param in a pkix test function. r=keeler
The only reason this param is a pointer is so that it can be optional. It's not
an outparam -- the function does not (and does not intend to) modify it -- so
it should be declared as 'const' to make that clearer & to allow clients to
pass in pointers to const values.
MozReview-Commit-ID: HbF96YNfnSt
--- a/security/pkix/test/lib/pkixtestutil.cpp
+++ b/security/pkix/test/lib/pkixtestutil.cpp
@@ -734,17 +734,17 @@ CreateEncodedSerialNumber(long serialNum
return Integer(serialNumberValue);
}
// BasicConstraints ::= SEQUENCE {
// cA BOOLEAN DEFAULT FALSE,
// pathLenConstraint INTEGER (0..MAX) OPTIONAL }
ByteString
CreateEncodedBasicConstraints(bool isCA,
- /*optional*/ long* pathLenConstraintValue,
+ /*optional in*/ const long* pathLenConstraintValue,
Critical critical)
{
ByteString value;
if (isCA) {
ByteString cA(Boolean(true));
value.append(cA);
}
--- a/security/pkix/test/lib/pkixtestutil.h
+++ b/security/pkix/test/lib/pkixtestutil.h
@@ -359,17 +359,17 @@ ByteString CreateEncodedCertificate(long
const TestKeyPair& issuerKeyPair,
const TestSignatureAlgorithm& signatureAlgorithm);
ByteString CreateEncodedSerialNumber(long value);
enum class Critical { No = 0, Yes = 1 };
ByteString CreateEncodedBasicConstraints(bool isCA,
- /*optional*/ long* pathLenConstraint,
+ /*optional in*/ const long* pathLenConstraint,
Critical critical);
// Creates a DER-encoded extKeyUsage extension with one EKU OID.
ByteString CreateEncodedEKUExtension(Input eku, Critical critical);
///////////////////////////////////////////////////////////////////////////////
// Encode OCSP responses
