Bug 1308337 - Part 5: Instrument FetchInfoCollectionsStage r=nalexander draft
authorGrigory Kruglov <gkruglov@mozilla.com>
Wed, 31 May 2017 17:38:30 -0400
changeset 588428 801c9c27730c217c6cf2d6e2bf086ef78f36f3a4
parent 588427 c4a10afafe83bbb404ad47a56b7c5c389c716dd6
child 588429 5e884830eaf1004e98ec1f6bca923fc4c84d1068
push id62031
push userbmo:gkruglov@mozilla.com
push dateFri, 02 Jun 2017 19:52:26 +0000
reviewersnalexander
bugs1308337
milestone55.0a1
Bug 1308337 - Part 5: Instrument FetchInfoCollectionsStage r=nalexander MozReview-Commit-ID: 64jTO81tDpK
mobile/android/services/src/main/java/org/mozilla/gecko/sync/stage/FetchInfoCollectionsStage.java
--- a/mobile/android/services/src/main/java/org/mozilla/gecko/sync/stage/FetchInfoCollectionsStage.java
+++ b/mobile/android/services/src/main/java/org/mozilla/gecko/sync/stage/FetchInfoCollectionsStage.java
@@ -1,44 +1,61 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 package org.mozilla.gecko.sync.stage;
 
+import android.os.SystemClock;
+
 import java.net.URISyntaxException;
 
 import org.mozilla.gecko.sync.ExtendedJSONObject;
+import org.mozilla.gecko.sync.HTTPFailureException;
 import org.mozilla.gecko.sync.InfoCollections;
 import org.mozilla.gecko.sync.delegates.JSONRecordFetchDelegate;
 import org.mozilla.gecko.sync.net.SyncStorageResponse;
+import org.mozilla.gecko.sync.telemetry.TelemetryCollector;
 
 public class FetchInfoCollectionsStage extends AbstractNonRepositorySyncStage {
   public class StageInfoCollectionsDelegate implements JSONRecordFetchDelegate {
 
     @Override
     public void handleSuccess(ExtendedJSONObject global) {
       session.config.infoCollections = new InfoCollections(global);
+      telemetryStageCollector.finished = SystemClock.elapsedRealtime();
       session.advance();
     }
 
     @Override
     public void handleFailure(SyncStorageResponse response) {
+      telemetryStageCollector.finished = SystemClock.elapsedRealtime();
+      telemetryStageCollector.error = new TelemetryCollector.StageErrorBuilder()
+              .setLastException(new HTTPFailureException(response))
+              .build();
       session.handleHTTPError(response, "Failure fetching info/collections.");
     }
 
     @Override
     public void handleError(Exception e) {
+      telemetryStageCollector.finished = SystemClock.elapsedRealtime();
+      telemetryStageCollector.error = new TelemetryCollector.StageErrorBuilder()
+              .setLastException(e)
+              .build();
       session.abort(e, "Failure fetching info/collections.");
     }
 
   }
 
   @Override
   public void execute() throws NoSuchStageException {
     try {
       session.fetchInfoCollections(new StageInfoCollectionsDelegate());
     } catch (URISyntaxException e) {
+      telemetryStageCollector.finished = SystemClock.elapsedRealtime();
+      telemetryStageCollector.error = new TelemetryCollector.StageErrorBuilder()
+              .setLastException(e)
+              .build();
       session.abort(e, "Invalid URI.");
     }
   }
 
 }