Bug 1369305 - Do not show a tooltip for the button will not open sub-dialog. draft
authorEvan Tseng <evan@tseng.io>
Fri, 02 Jun 2017 16:26:58 +0800
changeset 588163 0a450acc95590500431064a6c3f955f8d629aca0
parent 588052 aeb3d0ca558f034cbef1c5a68bd07dd738611494
child 631485 1d47f5f0d90039e19d78fd29b1487bf8aa34d02e
push id61936
push userbmo:evan@tseng.io
push dateFri, 02 Jun 2017 08:30:33 +0000
bugs1369305
milestone55.0a1
Bug 1369305 - Do not show a tooltip for the button will not open sub-dialog. MozReview-Commit-ID: 27bnOCJrhRI
browser/components/preferences/in-content-new/findInPage.js
--- a/browser/components/preferences/in-content-new/findInPage.js
+++ b/browser/components/preferences/in-content-new/findInPage.js
@@ -294,29 +294,19 @@ var gSearchResultsPane = {
       }
 
       // Access key are presented
       let complexTextNodesResult = this.highlightMatches(accessKeyTextNodes, nodeSizes, allNodeText.toLowerCase(), searchPhrase);
 
       // Searching some elements, such as xul:button, have a 'label' attribute that contains the user-visible text.
       let labelResult = this.stringMatchesFilters(nodeObject.getAttribute("label"), searchPhrase);
 
-      // Creating tooltips for buttons
-      if (labelResult && nodeObject.tagName === "button") {
-        this.listSearchTooltips.push(nodeObject);
-      }
-
       // Searching some elements, such as xul:label, store their user-visible text in a "value" attribute.
       let valueResult = this.stringMatchesFilters(nodeObject.getAttribute("value"), searchPhrase);
 
-      // Creating tooltips for buttons
-      if (valueResult && nodeObject.tagName === "button") {
-        this.listSearchTooltips.push(nodeObject);
-      }
-
       // Searching some elements, such as xul:button, buttons to open subdialogs.
       let keywordsResult = this.stringMatchesFilters(nodeObject.getAttribute("searchkeywords"), searchPhrase);
 
       // Creating tooltips for buttons
       if (keywordsResult && nodeObject.tagName === "button") {
         this.listSearchTooltips.push(nodeObject);
       }