Bug 1367318 - Trim console filter input. r=Honza draft
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Fri, 02 Jun 2017 09:52:27 +0200
changeset 588217 9daae96d601fa1404210a59a7f947ac6ad1f62fe
parent 588052 aeb3d0ca558f034cbef1c5a68bd07dd738611494
child 631510 0e2b2cb7f93b8b6d0c503ed88cde6fd5aca98445
push id61967
push userbmo:nchevobbe@mozilla.com
push dateFri, 02 Jun 2017 12:04:23 +0000
reviewersHonza
bugs1367318
milestone55.0a1
Bug 1367318 - Trim console filter input. r=Honza MozReview-Commit-ID: 8OAEUh6ekiP
devtools/client/webconsole/new-console-output/reducers/messages.js
devtools/client/webconsole/new-console-output/test/store/filters.test.js
--- a/devtools/client/webconsole/new-console-output/reducers/messages.js
+++ b/devtools/client/webconsole/new-console-output/reducers/messages.js
@@ -390,17 +390,17 @@ function matchNetworkFilters(message, fi
 function matchCssFilters(message, filters) {
   return (
     message.source != MESSAGE_SOURCE.CSS
     || filters.get("css") === true
   );
 }
 
 function matchSearchFilters(message, filters) {
-  let text = filters.text || "";
+  let text = (filters.text || "").trim();
   return (
     text === ""
     // Look for a match in parameters.
     || isTextInParameters(text, message.parameters)
     // Look for a match in location.
     || isTextInFrame(text, message.frame)
     // Look for a match in net events.
     || isTextInNetEvent(text, message.request)
--- a/devtools/client/webconsole/new-console-output/test/store/filters.test.js
+++ b/devtools/client/webconsole/new-console-output/test/store/filters.test.js
@@ -95,20 +95,30 @@ describe("Filtering", () => {
 
       store.dispatch(actions.filterToggle("net"));
       messages = getVisibleMessages(store.getState());
       expect(messages.length).toEqual(numMessages + 1);
     });
   });
 
   describe("Text filter", () => {
+    it("set the expected property on the store", () => {
+      store.dispatch(actions.filterTextSet("danger"));
+      expect(getAllFilters(store.getState()).text).toEqual("danger");
+    });
+
     it("matches on value grips", () => {
       store.dispatch(actions.filterTextSet("danger"));
       let messages = getVisibleMessages(store.getState());
       expect(messages.length - numUnfilterableMessages).toEqual(1);
+
+      // Checks that trimming works.
+      store.dispatch(actions.filterTextSet("    danger    "));
+      messages = getVisibleMessages(store.getState());
+      expect(messages.length - numUnfilterableMessages).toEqual(1);
     });
 
     it("matches unicode values", () => {
       store.dispatch(actions.filterTextSet("ιΌ¬"));
 
       let messages = getVisibleMessages(store.getState());
       expect(messages.length - numUnfilterableMessages).toEqual(1);
     });