Bug 1369322 - MediaResourceIndex follows ShouldCacheReads recommendation - r?cpearce draft
authorGerald Squelart <gsquelart@mozilla.com>
Fri, 02 Jun 2017 16:10:48 +1200
changeset 589328 57ea8a213177d1123f71a92b1b7cfb193092f863
parent 589327 d9a3fff6b40f06ee7eb561148eb30e2b61af97bd
child 631838 df819d6a492c26587af7cf684b0ee055e72070e0
push id62327
push usergsquelart@mozilla.com
push dateTue, 06 Jun 2017 02:16:26 +0000
reviewerscpearce
bugs1369322
milestone55.0a1
Bug 1369322 - MediaResourceIndex follows ShouldCacheReads recommendation - r?cpearce MozReview-Commit-ID: A8mtz2fJd71
dom/media/MediaResource.h
--- a/dom/media/MediaResource.h
+++ b/dom/media/MediaResource.h
@@ -764,17 +764,19 @@ private:
  */
 
 class MediaResourceIndex
 {
 public:
   explicit MediaResourceIndex(MediaResource* aResource)
     : mResource(aResource)
     , mOffset(0)
-    , mCacheBlockSize(SelectCacheSize(MediaPrefs::MediaResourceIndexCache()))
+    , mCacheBlockSize(aResource->ShouldCacheReads()
+                      ? SelectCacheSize(MediaPrefs::MediaResourceIndexCache())
+                      : 0 )
     , mCachedOffset(0)
     , mCachedBytes(0)
     , mCachedBlock(MakeUnique<char[]>(mCacheBlockSize))
   {}
 
   // Read up to aCount bytes from the stream. The buffer must have
   // enough room for at least aCount bytes. Stores the number of
   // actual bytes read in aBytes (0 on end of file).