Bug 1176415: verify absence of SSRC's in data channel m-sections. r?bwc draft
authorNils Ohlmeier [:drno] <drno@ohlmeier.org>
Thu, 01 Jun 2017 11:29:07 -0700
changeset 587810 1349aa8befed873e65495eb4f4a548482440c840
parent 587809 3ab7f781be7ff5fa7568890d82242e88cd7dfc5f
child 631372 68bc99b9699eefd01c60bb88c1026f9cfd9d0974
push id61817
push userdrno@ohlmeier.org
push dateThu, 01 Jun 2017 18:38:42 +0000
reviewersbwc
bugs1176415
milestone55.0a1
Bug 1176415: verify absence of SSRC's in data channel m-sections. r?bwc MozReview-Commit-ID: ADstE36mzzu
media/webrtc/signaling/gtest/jsep_session_unittest.cpp
--- a/media/webrtc/signaling/gtest/jsep_session_unittest.cpp
+++ b/media/webrtc/signaling/gtest/jsep_session_unittest.cpp
@@ -562,16 +562,21 @@ protected:
           std::string msidAttr("a=msid:");
           msidAttr += tracks[i]->GetStreamId();
           msidAttr += " ";
           msidAttr += tracks[i]->GetTrackId();
           ASSERT_NE(std::string::npos, offer.find(msidAttr))
             << "Did not find " << msidAttr << " in offer";
         }
       }
+      if (types.size() == 1 &&
+          tracks[0]->GetMediaType() == SdpMediaSection::kApplication) {
+        ASSERT_EQ(std::string::npos, offer.find("a=ssrc"))
+          << "Data channel should not contain SSRC";
+      }
     }
   }
 
   void
   SetRemoteOffer(const std::string& offer, uint32_t checkFlags = ALL_CHECKS)
   {
     nsresult rv = mSessionAns.SetRemoteDescription(kJsepSdpOffer, offer);
 
@@ -627,16 +632,21 @@ protected:
           std::string msidAttr("a=msid:");
           msidAttr += pairs[i].mSending->GetStreamId();
           msidAttr += " ";
           msidAttr += pairs[i].mSending->GetTrackId();
           ASSERT_NE(std::string::npos, answer.find(msidAttr))
             << "Did not find " << msidAttr << " in offer";
         }
       }
+      if (types.size() == 1 &&
+          pairs[0].mReceiving->GetMediaType() == SdpMediaSection::kApplication) {
+        ASSERT_EQ(std::string::npos, answer.find("a=ssrc"))
+          << "Data channel should not contain SSRC";
+      }
     }
     std::cerr << "OFFER pairs:" << std::endl;
     DumpTrackPairs(mSessionOff);
   }
 
   void
   SetRemoteAnswer(const std::string& answer, uint32_t checkFlags = ALL_CHECKS)
   {