Bug 1365402 - part 1: Normalize CRLF and CR to LF for textarea value property, r=baku draft
authorbtian <btian@mozilla.com>
Tue, 13 Jun 2017 10:17:54 +0800
changeset 592982 a19bf3506e88295920488e16e5b9a72e81ff9690
parent 592979 2a3a253806d129c0bb6f2b76bf75630457a24492
child 592983 14696ba3133ad68e39f41b6d4ba7defef8d4db95
push id63564
push userbmo:btian@mozilla.com
push dateTue, 13 Jun 2017 02:19:47 +0000
reviewersbaku
bugs1365402
milestone56.0a1
Bug 1365402 - part 1: Normalize CRLF and CR to LF for textarea value property, r=baku MozReview-Commit-ID: HDN4EfZ3n5K
dom/html/HTMLTextAreaElement.cpp
testing/web-platform/meta/html/semantics/forms/the-textarea-element/value-defaultValue-textContent.html.ini
--- a/dom/html/HTMLTextAreaElement.cpp
+++ b/dom/html/HTMLTextAreaElement.cpp
@@ -238,17 +238,23 @@ HTMLTextAreaElement::GetType(nsAString& 
   aType.AssignLiteral("textarea");
 
   return NS_OK;
 }
 
 NS_IMETHODIMP 
 HTMLTextAreaElement::GetValue(nsAString& aValue)
 {
-  GetValueInternal(aValue, true);
+  nsAutoString value;
+  GetValueInternal(value, true);
+
+  // Normalize CRLF and CR to LF
+  nsContentUtils::PlatformToDOMLineBreaks(value);
+
+  aValue = value;
   return NS_OK;
 }
 
 void
 HTMLTextAreaElement::GetValueInternal(nsAString& aValue, bool aIgnoreWrap) const
 {
   mState.GetValue(aValue, aIgnoreWrap);
 }
deleted file mode 100644
--- a/testing/web-platform/meta/html/semantics/forms/the-textarea-element/value-defaultValue-textContent.html.ini
+++ /dev/null
@@ -1,5 +0,0 @@
-[value-defaultValue-textContent.html]
-  type: testharness
-  [defaultValue and value treat CRLF differently]
-    expected: FAIL
-