Bug 1367367 - handle exception caused by late error callbacks. r?esawin draft
authorJohn Lin <jolin@mozilla.com>
Wed, 31 May 2017 15:31:13 +0800
changeset 586861 dcded703d7f1d9e77abc44167da39646cff3bf4b
parent 586775 9a5c710587f9e64bf044602d5e988b152ef4f40c
child 631129 767c665785fce7ac8762cba076a5672ba272f6db
push id61554
push userbmo:jolin@mozilla.com
push dateWed, 31 May 2017 07:32:22 +0000
reviewersesawin
bugs1367367
milestone55.0a1
Bug 1367367 - handle exception caused by late error callbacks. r?esawin MozReview-Commit-ID: 1xJ5S2wpHPd
mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/Codec.java
--- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/Codec.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/Codec.java
@@ -468,16 +468,18 @@ import org.mozilla.gecko.gfx.GeckoSurfac
     }
 
     private void reportError(Error error, Exception e) {
         if (e != null) {
             e.printStackTrace();
         }
         try {
             mCallbacks.onError(error == Error.FATAL);
+        } catch (NullPointerException ne) {
+            // mCallbacks has been disposed by release().
         } catch (RemoteException re) {
             re.printStackTrace();
         }
     }
 
     @Override
     public synchronized void stop() throws RemoteException {
         if (DEBUG) { Log.d(LOGTAG, "stop " + this); }