Bug 1334550 - Part 3 - Workaround for addon.uninstall() file locking issue; r=jimm draft
authorHaik Aftandilian <haftandilian@mozilla.com>
Mon, 29 May 2017 10:45:43 -0700
changeset 599104 1988e8881c41eb9199a9ef53b00796e4ce34b72e
parent 599103 8d769ecbc10c87e53dbd233087e59de059160927
child 634692 9e1fdcb3937b0680444bdd35b77ea7c02d897de3
push id65436
push userhaftandilian@mozilla.com
push dateThu, 22 Jun 2017 18:56:22 +0000
reviewersjimm
bugs1334550
milestone56.0a1
Bug 1334550 - Part 3 - Workaround for addon.uninstall() file locking issue; r=jimm MozReview-Commit-ID: HvWmnyuuipj
devtools/server/tests/mochitest/test_webextension-addon-debugging-reload.html
--- a/devtools/server/tests/mochitest/test_webextension-addon-debugging-reload.html
+++ b/devtools/server/tests/mochitest/test_webextension-addon-debugging-reload.html
@@ -101,16 +101,19 @@ async function test_reload_addon() {
   // is finally uninstalled.
 
   let {client} = addonTarget;
   let waitDebuggingClientClosed = new Promise(resolve => {
     addonTarget.once("close", resolve);
   });
 
   let waitShutdown = promiseWebExtensionShutdown();
+  // Disabling the add-on before uninstalling is necessary to cause tests to
+  // pass. This might be indicative of a bug in XPIProvider. Bug 992396.
+  addon.userDisabled = true;
   addon.uninstall();
   await waitShutdown;
 
   info("Waiting the addon target to be closed on addon uninstall");
   await waitDebuggingClientClosed;
 
   // Debugging client has to be closed explicitly when
   // the target has been created as remote.