Bug 1368289: Don't needlessly load ExtensionContent.jsm in all processes. r?mixedpuppy draft
authorKris Maglione <maglione.k@gmail.com>
Sat, 27 May 2017 17:25:30 -0700
changeset 585672 505912bd4ef3cbf322f67b6c1ea923c5d4160357
parent 585671 226440f49909034148a6aa9e6e7736e9d7ab70af
child 585673 97c36b5679052261352af14a0147fdd7c9d9cd16
push id61171
push usermaglione.k@gmail.com
push dateSun, 28 May 2017 00:33:11 +0000
reviewersmixedpuppy
bugs1368289
milestone55.0a1
Bug 1368289: Don't needlessly load ExtensionContent.jsm in all processes. r?mixedpuppy MozReview-Commit-ID: 2YBN5fDqI79
toolkit/components/extensions/Extension.jsm
toolkit/components/extensions/test/mochitest/test_ext_contentscript_cache.html
--- a/toolkit/components/extensions/Extension.jsm
+++ b/toolkit/components/extensions/Extension.jsm
@@ -1145,12 +1145,8 @@ this.Extension = class extends Extension
   get optionalOrigins() {
     if (this._optionalOrigins == null) {
       let origins = this.manifest.optional_permissions.filter(perm => classifyPermission(perm).origin);
       this._optionalOrigins = new MatchPatternSet(origins, {ignorePath: true});
     }
     return this._optionalOrigins;
   }
 };
-
-Services.ppmm.loadProcessScript("data:,new " + function() {
-  Components.utils.import("resource://gre/modules/ExtensionContent.jsm");
-}, true);
--- a/toolkit/components/extensions/test/mochitest/test_ext_contentscript_cache.html
+++ b/toolkit/components/extensions/test/mochitest/test_ext_contentscript_cache.html
@@ -62,17 +62,17 @@ add_task(async function test_contentscri
   let {appinfo} = SpecialPowers.Services;
   if (appinfo.processType === appinfo.PROCESS_TYPE_CONTENT) {
     /* globals addMessageListener, assert */
     chromeScript = SpecialPowers.loadChromeScript(() => {
       addMessageListener("check-script-cache", extensionId => {
         let {ExtensionManager} = Components.utils.import("resource://gre/modules/ExtensionChild.jsm", {});
         let ext = ExtensionManager.extensions.get(extensionId);
 
-        if (ext) {
+        if (ext && ext.staticScripts) {
           assert.equal(ext.staticScripts.size, 0, "Should have no cached scripts in the parent process");
         }
 
         sendAsyncMessage("done");
       });
     });
     chromeScript.sendAsyncMessage("check-script-cache", extension.id);
     chromeScriptDone = chromeScript.promiseOneMessage("done");