Bug 1354155 - create library button with initial history and synced tabs views, r?bgrins
MozReview-Commit-ID: J65DnluTXdA
--- a/browser/base/content/browser.xul
+++ b/browser/base/content/browser.xul
@@ -1190,16 +1190,21 @@
ondragenter="newWindowButtonObserver.onDragOver(event)"
ondragexit="newWindowButtonObserver.onDragExit(event)"/>
<toolbarbutton id="fullscreen-button" class="toolbarbutton-1 chromeclass-toolbar-additional"
observes="View:FullScreen"
type="checkbox"
label="&fullScreenCmd.label;"
tooltip="dynamic-shortcut-tooltip"/>
+#ifdef MOZ_PHOTON_THEME
+ <toolbarbutton id="library-button" class="toolbarbutton-1 chromeclass-toolbar-additional"
+ oncommand="PanelUI.showSubView('appMenu-libraryView', this, null, true);"
+ label="&places.library.title;"/>
+#endif
</toolbarpalette>
</toolbox>
<hbox id="fullscr-toggler" hidden="true"/>
<deck id="content-deck" flex="1">
<hbox flex="1" id="browser">
<vbox id="browser-border-start" hidden="true" layer="true"/>
--- a/browser/components/customizableui/content/panelUI.inc.xul
+++ b/browser/components/customizableui/content/panelUI.inc.xul
@@ -564,16 +564,45 @@
command="cmd_copy"
tooltip="dynamic-shortcut-tooltip"/>
<toolbarbutton id="appMenu-paste-button"
class="subviewbutton subviewbutton-iconic"
command="cmd_paste"
tooltip="dynamic-shortcut-tooltip"/>
</toolbaritem>
<toolbarseparator/>
+ <toolbarbutton id="appMenu-library-button"
+ class="subviewbutton subviewbutton-iconic subviewbutton-nav"
+ label="&places.library.title;"
+ closemenu="none"
+ oncommand="PanelUI.showSubView('appMenu-libraryView', this)"/>
+ <toolbarbutton id="appMenu-addons-button"
+ class="subviewbutton subviewbutton-iconic"
+ label="&addons.label;"
+ key="key_openAddons"
+ command="Tools:Addons"
+ />
+ <toolbarbutton id="appMenu-preferences-button"
+ class="subviewbutton subviewbutton-iconic"
+#ifdef XP_WIN
+ label="&preferencesCmd2.label;"
+#else
+ label="&preferencesCmdUnix.label;"
+#ifdef XP_MACOSX
+ key="key_preferencesCmdMac"
+#endif
+#endif
+ oncommand="openPreferences()"
+ />
+ <toolbarbutton id="appMenu-customize-button"
+ class="subviewbutton subviewbutton-iconic"
+ label="&viewCustomizeToolbar.label;"
+ command="cmd_CustomizeToolbars"
+ />
+ <toolbarseparator/>
<toolbarbutton id="appMenu-open-file-button"
class="subviewbutton"
label="&openFileCmd.label;"
key="openFileKb"
command="Browser:OpenFile"
/>
<toolbarbutton id="appMenu-save-file-button"
class="subviewbutton"
@@ -592,45 +621,16 @@
key="printKb"
#ifdef XP_MACOSX
command="cmd_print"
#else
command="cmd_printPreview"
#endif
/>
<toolbarseparator/>
- <toolbarbutton id="appMenu-library-button"
- class="subviewbutton subviewbutton-iconic"
- label="&places.library.title;"
- command="Browser:ShowAllBookmarks"
- />
- <toolbarbutton id="appMenu-addons-button"
- class="subviewbutton subviewbutton-iconic"
- label="&addons.label;"
- key="key_openAddons"
- command="Tools:Addons"
- />
- <toolbarbutton id="appMenu-preferences-button"
- class="subviewbutton subviewbutton-iconic"
-#ifdef XP_WIN
- label="&preferencesCmd2.label;"
-#else
- label="&preferencesCmdUnix.label;"
-#ifdef XP_MACOSX
- key="key_preferencesCmdMac"
-#endif
-#endif
- oncommand="openPreferences()"
- />
- <toolbarbutton id="appMenu-customize-button"
- class="subviewbutton subviewbutton-iconic"
- label="&viewCustomizeToolbar.label;"
- command="cmd_CustomizeToolbars"
- />
- <toolbarseparator/>
<toolbarbutton id="appMenu-find-button"
class="subviewbutton subviewbutton-iconic"
label="&findOnCmd.label;"
key="key_find"
command="cmd_find"/>
<toolbarbutton id="appMenu-more-button"
class="subviewbutton subviewbutton-nav"
label="&moreMenu.label;"
@@ -671,10 +671,24 @@
<toolbarbutton id="appMenu-workoffline-button"
class="subviewbutton"
label="&goOfflineCmd.label;"
type="checkbox"
observes="workOfflineMenuitemState"
oncommand="BrowserOffline.toggleOfflineStatus();"/>
</vbox>
</panelview>
+ <panelview id="appMenu-libraryView" class="PanelUI-subView">
+ <vbox class="panel-subview-body">
+ <toolbarbutton id="appMenu-library-history-button"
+ class="subviewbutton subviewbutton-iconic subviewbutton-nav"
+ label="&historyMenu.label;"
+ closemenu="none"
+ oncommand="PanelUI.showSubView('PanelUI-history', this)"/>
+ <toolbarbutton id="appMenu-library-remotetabs-button"
+ class="subviewbutton subviewbutton-iconic subviewbutton-nav"
+ label="&appMenuRemoteTabs.label;"
+ closemenu="none"
+ oncommand="PanelUI.showSubView('PanelUI-remotetabs', this)"/>
+ </vbox>
+ </panelview>
</photonpanelmultiview>
</panel>
--- a/browser/themes/shared/browser.inc
+++ b/browser/themes/shared/browser.inc
@@ -1,16 +1,16 @@
%filter substitution
% Note that zoom-reset-button is a bit different since it doesn't use an image and thus has the image with display: none.
%define nestedButtons #zoom-out-button, #zoom-reset-button, #zoom-in-button, #cut-button, #copy-button, #paste-button
%define primaryToolbarButtons #back-button, #forward-button, #home-button, #print-button, #downloads-button, #bookmarks-menu-button, #new-tab-button, #new-window-button, #fullscreen-button, #sync-button, #feed-button, #social-share-button, #open-file-button, #find-button, #developer-button, #preferences-button, #privatebrowsing-button, #save-page-button, #add-ons-button, #history-panelmenu, #nav-bar-overflow-button, #PanelUI-menu-button, #characterencoding-button, #email-link-button, #sidebar-button, @nestedButtons@, #e10s-button, #panic-button, #webide-button, #containers-panelmenu
%ifdef MOZ_PHOTON_THEME
-%define primaryToolbarButtons @primaryToolbarButtons@, #reload-button, #stop-button
+%define primaryToolbarButtons @primaryToolbarButtons@, #reload-button, #stop-button, #library-button
%endif
%ifdef XP_MACOSX
% Prior to 10.7 there wasn't a native fullscreen button so we use #restore-button to exit fullscreen
% and want it to behave like other toolbar buttons.
%define primaryToolbarButtons @primaryToolbarButtons@, #restore-button
%endif
--- a/browser/themes/shared/toolbarbutton-icons.inc.css
+++ b/browser/themes/shared/toolbarbutton-icons.inc.css
@@ -191,8 +191,12 @@ toolbar:not([brighttext]) #bookmarks-men
#panic-button[cui-areatype="toolbar"][open] {
fill: rgb(213, 32, 20);
}
#webide-button[cui-areatype="toolbar"] {
list-style-image: url("chrome://browser/skin/webIDE.svg");
}
+
+#library-button {
+ list-style-image: url("chrome://browser/skin/library.svg");
+}