Bug 1360282 - Use querySelectorAll instead of getElementsByAttribute and a condition;r=Gijs draft
authorBrian Grinstead <bgrinstead@mozilla.com>
Tue, 13 Jun 2017 08:14:57 -0700
changeset 593454 6a76148a3adaef616df2107f62d2a1138dd86aa0
parent 593453 dc1f7224f62af95c50672e278613da7951db8571
child 593455 ed67bebb88ca18ba009d3b943d52086e648161f4
push id63696
push userbgrinstead@mozilla.com
push dateTue, 13 Jun 2017 15:15:10 +0000
reviewersGijs
bugs1360282
milestone56.0a1
Bug 1360282 - Use querySelectorAll instead of getElementsByAttribute and a condition;r=Gijs MozReview-Commit-ID: Fq6pXxiSZ7b
browser/base/content/browser-sidebar.js
--- a/browser/base/content/browser-sidebar.js
+++ b/browser/base/content/browser-sidebar.js
@@ -313,24 +313,18 @@ var SidebarUI = {
         reject(new Error("Invalid sidebar broadcaster specified: " + commandID));
         return;
       }
 
       if (this.isOpen && commandID != this.currentID) {
         BrowserUITelemetry.countSidebarEvent(this.currentID, "hide");
       }
 
-      let broadcasters = document.getElementsByAttribute("group", "sidebar");
+      let broadcasters = document.querySelectorAll("broadcaster[group=sidebar]");
       for (let broadcaster of broadcasters) {
-        // skip elements that observe sidebar broadcasters and random
-        // other elements
-        if (broadcaster.localName != "broadcaster") {
-          continue;
-        }
-
         if (broadcaster != sidebarBroadcaster) {
           broadcaster.removeAttribute("checked");
         } else {
           sidebarBroadcaster.setAttribute("checked", "true");
         }
       }
 
       this._setVisibility(true);