Bug 1340637 - Disable geckodriver compilation on Linux i686; r=me draft
authorAndreas Tolfsen <ato@mozilla.com>
Wed, 24 May 2017 19:45:43 +0100
changeset 584516 d9a5bb1066c4f7853ff40c411958e5322d80bd33
parent 584515 3f5d815b9d334a36d8f1ce3ddd514df7b6ee818f
child 630412 b015cdf28a8ef69b0b95a5e1e2666f064475376b
push id60773
push userbmo:ato@mozilla.com
push dateThu, 25 May 2017 16:41:40 +0000
reviewersme
bugs1340637, 1367519
milestone55.0a1
Bug 1340637 - Disable geckodriver compilation on Linux i686; r=me geckodriver fails to cross-compile on the TaskCluster x86_64 VMs to Linux i686. This patch disables building on that platform, and I have filed https://bugzilla.mozilla.org/show_bug.cgi?id=1367519 to follow up on this. MozReview-Commit-ID: 7GEx2Oog2fS
toolkit/toolkit.mozbuild
--- a/toolkit/toolkit.mozbuild
+++ b/toolkit/toolkit.mozbuild
@@ -151,23 +151,28 @@ DIRS += ['/addon-sdk']
 if CONFIG['ENABLE_MARIONETTE']:
     DIRS += [
         '/testing/firefox-ui',
         '/testing/marionette',
     ]
 
     # Disable building of geckodriver for artifact builds and in
     # environments where cross compiling occurs (macOS and Android),
-    # and on hazard builds.
+    # on hazard builds, and on Linux x86 (linking problems).
     #
     # https://bugzilla.mozilla.org/show_bug.cgi?id=1341041
     # https://bugzilla.mozilla.org/show_bug.cgi?id=1329737
-    if CONFIG['COMPILE_ENVIRONMENT'] and \
-            not CONFIG['CROSS_COMPILE'] and \
-            not CONFIG['MOZ_HAZARD']:
+    # https://bugzilla.mozilla.org/show_bug.cgi?id=1367519
+    # https://bugzilla.mozilla.org/show_bug.cgi?id=1367736
+    if (not CONFIG['COMPILE_ENVIRONMENT'] or
+            CONFIG['CROSS_COMPILE'] or
+            (CONFIG['OS_TARGET'] == 'Linux' and CONFIG['TARGET_CPU'] == 'i686') or
+            CONFIG['MOZ_HAZARD']):
+        pass
+    else:
         DIRS += ['/testing/geckodriver']
 
 DIRS += [
     '/tools/quitter',
     '/media/gmp-clearkey/0.1',
 ]
 
 if CONFIG['ENABLE_TESTS']: