Bug 816784 part 4 - Fix the rooting hazards that the analysis report. r?sfink draft
authorTing-Yu Chou <janus926@gmail.com>
Tue, 23 May 2017 11:45:17 +0800
changeset 583481 e98603fa739af64d13ae713c18ca0825c51e4b32
parent 582208 c2846145a6d5765366e41bf8c71c50982b7f93f6
child 630071 a8dfe08f5e8b52b0e4f7ba1aada9ea93410a2e6e
push id60408
push userbmo:janus926@gmail.com
push dateWed, 24 May 2017 04:08:15 +0000
reviewerssfink
bugs816784
milestone55.0a1
Bug 816784 part 4 - Fix the rooting hazards that the analysis report. r?sfink WrapperMap::Enum::goToNext() is listed as a GC function because the *generated* stack calls BrowserCompartmentMatcher::match() which leads a path to a FieldCall of nsISupports.QueryInterface, however it is never the case. Add nsContentUtils::IsExpandedPrincipal() to the ignore functions because it is more narrowly scoped and therefore less likely to hide problems. MozReview-Commit-ID: ACwkMtRiQk2
js/src/devtools/rootAnalysis/annotations.js
--- a/js/src/devtools/rootAnalysis/annotations.js
+++ b/js/src/devtools/rootAnalysis/annotations.js
@@ -226,16 +226,18 @@ var ignoreFunctions = {
 
     // VTune internals that lazy-load a shared library and make IndirectCalls.
     "iJIT_IsProfilingActive" : true,
     "iJIT_NotifyEvent": true,
 
     // The big hammers.
     "PR_GetCurrentThread" : true,
     "calloc" : true,
+
+    "uint8 nsContentUtils::IsExpandedPrincipal(nsIPrincipal*)" : true,
 };
 
 function extraGCFunctions() {
     return ["ffi_call"];
 }
 
 function isProtobuf(name)
 {