Bug 1366882 - Fix a resource leak - CID 221217 - r?ted draft
authorSylvestre Ledru <sledru@mozilla.com>
Mon, 22 May 2017 23:23:08 +0200
changeset 583828 6fd7597c3991ee3e4cd5b6d019f5f4c87aa2f425
parent 583827 1208810af4397a5fd0a1a27cfb3d137f335bde1b
child 630224 90a62f772b77bf2b1aff34108433fe6ccf9232da
push id60571
push userbmo:sledru@mozilla.com
push dateWed, 24 May 2017 18:10:53 +0000
reviewersted
bugs1366882, 221217
milestone55.0a1
Bug 1366882 - Fix a resource leak - CID 221217 - r?ted MozReview-Commit-ID: G3THkXZN9GA
toolkit/crashreporter/client/crashreporter_gtk_common.cpp
--- a/toolkit/crashreporter/client/crashreporter_gtk_common.cpp
+++ b/toolkit/crashreporter/client/crashreporter_gtk_common.cpp
@@ -71,18 +71,20 @@ static bool RestartApplication()
 
   unsigned int i;
   for (i = 0; i < gRestartArgs.size(); i++) {
     argv[i] = (char*)gRestartArgs[i].c_str();
   }
   argv[i] = 0;
 
   pid_t pid = fork();
-  if (pid == -1)
+  if (pid == -1) {
+    free(argv);
     return false;
+  }
   else if (pid == 0) {
     (void)execv(argv[0], argv);
     _exit(1);
   }
 
   free(argv);
 
   return true;