Bug 1366720 - ESLint simpletest and places-overlay environments don't export globals correctly when used outside of mozilla-central. r?Mossop draft
authorMark Banner <standard8@mozilla.com>
Mon, 22 May 2017 11:25:08 +0100
changeset 582365 a952e108b3f992fb3cd3257cc6a8060e72f9d588
parent 582257 9851fcb0bf4d855c36729d7de19f0fa5c9f69776
child 629744 8d8d4b4c96b905bf3b0e104049b4936f8a4d5a32
push id60054
push userbmo:standard8@mozilla.com
push dateMon, 22 May 2017 10:25:45 +0000
reviewersMossop
bugs1366720
milestone55.0a1
Bug 1366720 - ESLint simpletest and places-overlay environments don't export globals correctly when used outside of mozilla-central. r?Mossop MozReview-Commit-ID: 1Qj63qwjHoo
tools/lint/eslint/eslint-plugin-mozilla/lib/environments/places-overlay.js
tools/lint/eslint/eslint-plugin-mozilla/lib/environments/simpletest.js
tools/lint/eslint/eslint-plugin-mozilla/package.json
--- a/tools/lint/eslint/eslint-plugin-mozilla/lib/environments/places-overlay.js
+++ b/tools/lint/eslint/eslint-plugin-mozilla/lib/environments/places-overlay.js
@@ -71,10 +71,10 @@ function mapGlobals(fileGlobals) {
     globalObjects[global.name] = global.writable;
   }
   return globalObjects;
 }
 
 module.exports = {
   globals: helpers.isMozillaCentralBased() ?
     mapGlobals(getScriptGlobals()) :
-    helpers.getSavedEnvironmentItems("places-overlay")
+    helpers.getSavedEnvironmentItems("places-overlay").globals
 };
--- a/tools/lint/eslint/eslint-plugin-mozilla/lib/environments/simpletest.js
+++ b/tools/lint/eslint/eslint-plugin-mozilla/lib/environments/simpletest.js
@@ -48,10 +48,10 @@ function mapGlobals(fileGlobals) {
     globalObjects[global.name] = global.writable;
   }
   return globalObjects;
 }
 
 module.exports = {
   globals: helpers.isMozillaCentralBased() ?
     mapGlobals(getScriptGlobals()) :
-    helpers.getSavedEnvironmentItems("simpletest")
+    helpers.getSavedEnvironmentItems("simpletest").globals
 };
--- a/tools/lint/eslint/eslint-plugin-mozilla/package.json
+++ b/tools/lint/eslint/eslint-plugin-mozilla/package.json
@@ -1,11 +1,11 @@
 {
   "name": "eslint-plugin-mozilla",
-  "version": "0.3.1",
+  "version": "0.3.2",
   "description": "A collection of rules that help enforce JavaScript coding standard in the Mozilla project.",
   "keywords": [
     "eslint",
     "eslintplugin",
     "eslint-plugin",
     "mozilla",
     "firefox"
   ],