Bug 1366657 - Set stylesheet and parent rules properly for keyframe rules. r?heycam draft
authorXidorn Quan <me@upsuper.org>
Mon, 22 May 2017 16:05:14 +1000
changeset 582747 c7fdff9a21dc566f187c5cea3f2250a7f06385f8
parent 582746 ff03800307d59d836071bf34d0ded25524c8d856
child 582797 8df1962819047b447c719b91f6a465c5e3450a7f
child 582805 058c9078300cd0d5c466a1954bba89d6c62f8c63
child 582849 3ac60c73d7c8dc886123f2bdb0481dd6b118f4bc
push id60157
push userxquan@mozilla.com
push dateTue, 23 May 2017 01:41:34 +0000
reviewersheycam
bugs1366657
milestone55.0a1
Bug 1366657 - Set stylesheet and parent rules properly for keyframe rules. r?heycam MozReview-Commit-ID: CdIm4IypeN0
layout/style/ServoKeyframesRule.cpp
layout/style/test/stylo-failures.md
--- a/layout/style/ServoKeyframesRule.cpp
+++ b/layout/style/ServoKeyframesRule.cpp
@@ -51,16 +51,18 @@ public:
 
   ServoStyleSheet* GetParentObject() final { return mStyleSheet; }
 
   ServoKeyframeRule* GetRule(uint32_t aIndex) {
     if (!mRules[aIndex]) {
       ServoKeyframeRule* rule = new ServoKeyframeRule(
         Servo_KeyframesRule_GetKeyframe(mRawRule, aIndex).Consume());
       mRules.ReplaceObjectAt(rule, aIndex);
+      rule->SetStyleSheet(mStyleSheet);
+      rule->SetParentRule(mParentRule);
     }
     return static_cast<ServoKeyframeRule*>(mRules[aIndex]);
   }
 
   ServoKeyframeRule* IndexedGetter(uint32_t aIndex, bool& aFound) final
   {
     if (aIndex >= mRules.Length()) {
       aFound = false;
--- a/layout/style/test/stylo-failures.md
+++ b/layout/style/test/stylo-failures.md
@@ -31,21 +31,18 @@ to mochitest command.
 
 * Media query support:
   * test_media_queries.html [38]
   * test_media_queries_dynamic.html [6]
   * test_media_queries_dynamic_xbl.html [2]
   * test_webkit_device_pixel_ratio.html: -webkit-device-pixel-ratio [3]
   * browser_bug453896.js [8]
 * Animation support:
-  * test_animations.html [1]
-  * test_animations_dynamic_changes.html [1]
-  * test_bug716226.html [3]
   * OMTA
-    * test_animations_omta.html: bug 1361938, bug 1361663 [85]
+    * test_animations_omta.html: bug 1361938, bug 1361663 [*]
   * SMIL Animation
     * test_restyles_in_smil_animation.html [2]
 * CSSOM support:
   * \@import bug 1352968
     * test_bug221428.html [1]
     * test_css_eof_handling.html [1]
 * test_bug397427.html: @import issue bug 1331291 and CSSOM support of @import [1]
 * console support bug 1352669