Bug 1366474: While we're here, devirtualize GetSMILOverrideStyle too. r?birtles draft
authorEmilio Cobos Álvarez <emilio@crisal.io>
Sat, 20 May 2017 13:02:43 +0200
changeset 581961 c8c65c2fd29d8200b62daea192c951bea905e268
parent 581960 d2f85b6184af4a11e0d1dc19410cdd718c178153
child 581968 16e383b65612854f666f479123cdf671586ac4d4
push id59926
push userbmo:emilio+bugs@crisal.io
push dateSat, 20 May 2017 11:05:20 +0000
reviewersbirtles
bugs1366474
milestone55.0a1
Bug 1366474: While we're here, devirtualize GetSMILOverrideStyle too. r?birtles Also, update an outdated comment that was leftover. MozReview-Commit-ID: CC865rj3o3S
dom/base/Element.h
dom/base/FragmentOrElement.h
--- a/dom/base/Element.h
+++ b/dom/base/Element.h
@@ -352,17 +352,17 @@ public:
   /**
    * Get the SMIL override style for this element. This is a style declaration
    * that is applied *after* the inline style, and it can be used e.g. to store
    * animated style values.
    *
    * Note: This method is analogous to the 'GetStyle' method in
    * nsGenericHTMLElement and nsStyledElement.
    */
-  virtual nsICSSDeclaration* GetSMILOverrideStyle();
+  nsICSSDeclaration* GetSMILOverrideStyle();
 
   /**
    * Returns if the element is labelable as per HTML specification.
    */
   virtual bool IsLabelable() const;
 
   /**
    * Returns if the element is interactive content as per HTML specification.
--- a/dom/base/FragmentOrElement.h
+++ b/dom/base/FragmentOrElement.h
@@ -270,17 +270,17 @@ public:
     /**
      * The .dataset attribute.
      * @see nsGenericHTMLElement::GetDataset
      */
     nsDOMStringMap* mDataset; // [Weak]
 
     /**
      * SMIL Overridde style rules (for SMIL animation of CSS properties)
-     * @see nsIContent::GetSMILOverrideStyle
+     * @see Element::GetSMILOverrideStyle
      */
     nsCOMPtr<nsICSSDeclaration> mSMILOverrideStyle;
 
     /**
      * Holds any SMIL override style declaration for this element.
      */
     RefPtr<mozilla::DeclarationBlock> mSMILOverrideStyleDeclaration;