Bug 1366061 - Fix memory tool file picker; r?fitzgen
MozReview-Commit-ID: JNrIGmXlZ46
--- a/devtools/client/memory/utils.js
+++ b/devtools/client/memory/utils.js
@@ -409,25 +409,27 @@ exports.getSnapshotTotals = function (ce
* @param {String} .defaultName
* The default name chosen by the file picker window.
* @param {String} .mode
* The mode that this filepicker should open in. Can be "open" or "save".
* @return {Promise<?nsILocalFile>}
* The file selected by the user, or null, if cancelled.
*/
exports.openFilePicker = function ({ title, filters, defaultName, mode }) {
- mode = mode === "save" ? Ci.nsIFilePicker.modeSave : null;
- mode = mode === "open" ? Ci.nsIFilePicker.modeOpen : null;
-
- if (mode == void 0) {
+ let fpMode;
+ if (mode === "save") {
+ fpMode = Ci.nsIFilePicker.modeSave;
+ } else if (mode === "open") {
+ fpMode = Ci.nsIFilePicker.modeOpen;
+ } else {
throw new Error("No valid mode specified for nsIFilePicker.");
}
let fp = Cc["@mozilla.org/filepicker;1"].createInstance(Ci.nsIFilePicker);
- fp.init(window, title, mode);
+ fp.init(window, title, fpMode);
for (let filter of (filters || [])) {
fp.appendFilter(filter[0], filter[1]);
}
fp.defaultString = defaultName;
return new Promise(resolve => {
fp.open({