Bug 1366278 - Get rid of --urlbar-background-color since it's always -moz-field and textbox.css already sets that by default. draft
authorDão Gottwald <dao@mozilla.com>
Fri, 19 May 2017 16:50:10 +0200
changeset 581231 4edaee6106621099bdc7107b308372ec2bfca864
parent 580912 8e98dab5054dd093a37ba20c62cf0523e484cfbd
child 629525 41be7f1608b014fe9fd3d211b5874cbe5a927796
push id59814
push userdgottwald@mozilla.com
push dateFri, 19 May 2017 14:50:35 +0000
bugs1366278
milestone55.0a1
Bug 1366278 - Get rid of --urlbar-background-color since it's always -moz-field and textbox.css already sets that by default. MozReview-Commit-ID: 5OCZPxrQtST
browser/themes/linux/browser.css
browser/themes/osx/browser.css
browser/themes/shared/urlbar-searchbar.inc.css
browser/themes/windows/browser.css
--- a/browser/themes/linux/browser.css
+++ b/browser/themes/linux/browser.css
@@ -263,23 +263,27 @@ menuitem.bookmark-item {
 #close-button {
   list-style-image: url("chrome://global/skin/icons/Close.gif");
 }
 
 /* Location bar */
 #main-window {
   --urlbar-border-color: ThreeDShadow;
   --urlbar-border-color-hover: var(--urlbar-border-color);
-  --urlbar-background-color: -moz-field;
 }
 
 #navigator-toolbox:-moz-lwtheme {
   --urlbar-border-color: rgba(0,0,0,.3);
 }
 
+#urlbar {
+  /* override textbox[enablehistory="true"] styling: */
+  background-color: -moz-field;
+}
+
 %include ../shared/urlbar-searchbar.inc.css
 
 %ifdef MOZ_PHOTON_THEME
 
 #urlbar[focused="true"],
 .searchbar-textbox[focused="true"] {
   border-color: Highlight;
 }
@@ -296,20 +300,16 @@ menuitem.bookmark-item {
   margin: 0 3px;
 }
 
 #urlbar[focused],
 .searchbar-textbox[focused] {
   border-color: Highlight;
 }
 
-#urlbar {
-  background-color: -moz-field;
-}
-
 #urlbar:-moz-lwtheme,
 .searchbar-textbox:-moz-lwtheme {
   background-color: rgba(255,255,255,.8);
   color: black;
 }
 
 #urlbar:-moz-lwtheme[focused=true],
 .searchbar-textbox:-moz-lwtheme[focused=true] {
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -522,17 +522,16 @@ toolbarpaletteitem[place="palette"] > #p
 
 %include ../shared/urlbar-searchbar.inc.css
 
 %ifdef MOZ_PHOTON_THEME
 
 #main-window {
   --urlbar-border-color: hsla(240, 5%, 5%, .25);
   --urlbar-border-color-hover: hsla(240, 5%, 5%, .35);
-  --urlbar-background-color: -moz-field;
 }
 
 #urlbar[focused="true"],
 .searchbar-textbox[focused="true"] {
   border-color: -moz-mac-focusring;
   box-shadow: var(--focus-ring-box-shadow);
 }
 
--- a/browser/themes/shared/urlbar-searchbar.inc.css
+++ b/browser/themes/shared/urlbar-searchbar.inc.css
@@ -3,17 +3,16 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 %ifdef MOZ_PHOTON_THEME
 
 #urlbar,
 .searchbar-textbox {
   -moz-appearance: none;
   background-clip: content-box;
-  background-color: var(--urlbar-background-color);
   border: 1px solid var(--urlbar-border-color);
   border-radius: var(--toolbarbutton-border-radius);
   box-shadow: 0 1px 4px hsla(0, 0%, 0%, .05);
   padding: 0;
   margin: 0 5px;
   min-height: 30px;
 }
 
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -665,17 +665,16 @@ toolbar[brighttext] #close-button {
 %include ../shared/urlbar-searchbar.inc.css
 
 %ifdef MOZ_PHOTON_THEME
 
 @media (-moz-windows-default-theme) {
   #main-window:not(:-moz-lwtheme) {
     --urlbar-border-color: hsla(240, 5%, 5%, .25);
     --urlbar-border-color-hover: hsla(240, 5%, 5%, .35);
-    --urlbar-background-color: -moz-field;
   }
 }
 
 #urlbar,
 .searchbar-textbox {
   font-size: 1.15em;
 }