Bug 1362149 - Minor code cleanup. r=dimi draft
authorFelipe Gomes <felipc@gmail.com>
Thu, 18 May 2017 23:01:01 -0300
changeset 580848 87a4c8e4e4407aabe72597acce45c714f3c297ec
parent 580846 8a980c64e1175318202bb919f4b26a5601661b2e
child 629401 afff515c494fffc8c87b32dc3558916c3541564c
push id59679
push userfelipc@gmail.com
push dateFri, 19 May 2017 02:01:41 +0000
reviewersdimi
bugs1362149
milestone55.0a1
Bug 1362149 - Minor code cleanup. r=dimi Remove dead code and switch a hardcoded value to use its properly defined constant MozReview-Commit-ID: E1cgtPvaV3M
toolkit/components/url-classifier/HashStore.cpp
--- a/toolkit/components/url-classifier/HashStore.cpp
+++ b/toolkit/components/url-classifier/HashStore.cpp
@@ -516,23 +516,16 @@ HashStore::ReadHashes()
 
 nsresult
 HashStore::ReadCompletions()
 {
   if (!mInputStream || AlreadyReadCompletions()) {
     return NS_OK;
   }
 
-  nsCOMPtr<nsIFile> storeFile;
-  nsresult rv = mStoreDirectory->Clone(getter_AddRefs(storeFile));
-  NS_ENSURE_SUCCESS(rv, rv);
-
-  rv = storeFile->AppendNative(mTableName + NS_LITERAL_CSTRING(STORE_SUFFIX));
-  NS_ENSURE_SUCCESS(rv, rv);
-
   uint32_t offset = mFileSize -
                     sizeof(struct AddComplete) * mHeader.numAddCompletes -
                     sizeof(struct SubComplete) * mHeader.numSubCompletes -
                     nsCheckSummedOutputStream::CHECKSUM_SIZE;
 
   nsCOMPtr<nsISeekableStream> seekable = do_QueryInterface(mInputStream);
 
   rv = seekable->Seek(nsISeekableStream::NS_SEEK_SET, offset);
@@ -990,17 +983,17 @@ HashStore::WriteFile()
   NS_ASSERTION(mInUpdate, "Must be in update to write database.");
   if (nsUrlClassifierDBService::ShutdownHasStarted()) {
     return NS_ERROR_ABORT;
   }
 
   nsCOMPtr<nsIFile> storeFile;
   nsresult rv = mStoreDirectory->Clone(getter_AddRefs(storeFile));
   NS_ENSURE_SUCCESS(rv, rv);
-  rv = storeFile->AppendNative(mTableName + NS_LITERAL_CSTRING(".sbstore"));
+  rv = storeFile->AppendNative(mTableName + NS_LITERAL_CSTRING(STORE_SUFFIX));
   NS_ENSURE_SUCCESS(rv, rv);
 
   nsCOMPtr<nsIOutputStream> out;
   rv = NS_NewCheckSummedOutputStream(getter_AddRefs(out), storeFile,
                                      PR_WRONLY | PR_TRUNCATE | PR_CREATE_FILE);
   NS_ENSURE_SUCCESS(rv, rv);
 
   uint32_t written;