Bug 1336540 part 3 - Remove --with-gecko from build-geckolib because it is not usable. r?emilio draft
authorXidorn Quan <me@upsuper.org>
Thu, 18 May 2017 18:20:25 +1000
changeset 580265 b3f58477384deb0ce20f720d5bcf5ea718cdbf51
parent 580264 f4827b627e37f4ddc705da495852a5f681fb9611
child 629224 de2689f96949d89922ab22f869840be38cc89c62
push id59488
push userxquan@mozilla.com
push dateThu, 18 May 2017 09:11:54 +0000
reviewersemilio
bugs1336540
milestone55.0a1
Bug 1336540 part 3 - Remove --with-gecko from build-geckolib because it is not usable. r?emilio MozReview-Commit-ID: 26UsnoPTHei
servo/python/servo/build_commands.py
--- a/servo/python/servo/build_commands.py
+++ b/servo/python/servo/build_commands.py
@@ -402,41 +402,35 @@ class MachCommands(CommandBase):
 
         print("CEF build completed in %s" % format_duration(elapsed))
 
         return ret
 
     @Command('build-geckolib',
              description='Build a static library of components used by Gecko',
              category='build')
-    @CommandArgument('--with-gecko',
-                     default=None,
-                     help='Build with Gecko dist directory')
     @CommandArgument('--jobs', '-j',
                      default=None,
                      help='Number of jobs to run in parallel')
     @CommandArgument('--verbose', '-v',
                      action='store_true',
                      help='Print verbose output')
     @CommandArgument('--release', '-r',
                      action='store_true',
                      help='Build in release mode')
-    def build_geckolib(self, with_gecko=None, jobs=None, verbose=False, release=False):
+    def build_geckolib(self, jobs=None, verbose=False, release=False):
         self.set_use_stable_rust()
         self.ensure_bootstrapped()
         self.ensure_clobbered()
 
         env = self.build_env(is_build=True, geckolib=True)
 
         ret = None
         opts = []
         features = []
-        if with_gecko is not None:
-            features += ["bindgen"]
-            env["MOZ_DIST"] = path.abspath(path.expanduser(with_gecko))
         if jobs is not None:
             opts += ["-j", jobs]
         if verbose:
             opts += ["-v"]
         if release:
             opts += ["--release"]
         else:
             features += ["gecko_debug"]