Bug 1365460 - Expand the __crtInitCritSecAndSpinCount macro and remove it. r?njn draft
authorMike Hommey <mh+mozilla@glandium.org>
Thu, 18 May 2017 10:39:08 +0900
changeset 580758 d8b3bec50929ade8d16fc143e80e0fd36ed570d7
parent 580757 26d72966dc3a9eac568156fbc18caccfc46b3842
child 580759 46384aaa0e54ca91c08756375c0ca3a93a19e279
push id59654
push userbmo:mh+mozilla@glandium.org
push dateThu, 18 May 2017 22:44:22 +0000
reviewersnjn
bugs1365460
milestone55.0a1
Bug 1365460 - Expand the __crtInitCritSecAndSpinCount macro and remove it. r?njn
memory/mozjemalloc/mozjemalloc.cpp
--- a/memory/mozjemalloc/mozjemalloc.cpp
+++ b/memory/mozjemalloc/mozjemalloc.cpp
@@ -145,17 +145,16 @@
 #include <stdarg.h>
 #include <stdio.h>
 #include <string.h>
 
 #ifdef MOZ_MEMORY_WINDOWS
 
 /* Some defines from the CRT internal headers that we need here. */
 #define _CRT_SPINCOUNT 5000
-#define __crtInitCritSecAndSpinCount InitializeCriticalSectionAndSpinCount
 #include <io.h>
 #include <windows.h>
 #include <intrin.h>
 #include <algorithm>
 
 #pragma warning( disable: 4267 4996 4146 )
 
 #define	SIZE_T_MAX SIZE_MAX
@@ -1235,17 +1234,17 @@ int pthread_atfork(void (*)(void), void 
  * they require malloc()ed memory, which causes bootstrapping issues in some
  * cases.
  */
 
 static bool
 malloc_mutex_init(malloc_mutex_t *mutex)
 {
 #if defined(MOZ_MEMORY_WINDOWS)
-	if (! __crtInitCritSecAndSpinCount(mutex, _CRT_SPINCOUNT))
+	if (!InitializeCriticalSectionAndSpinCount(mutex, _CRT_SPINCOUNT))
 		return (true);
 #elif defined(MOZ_MEMORY_DARWIN)
 	mutex->lock = OS_SPINLOCK_INIT;
 #elif defined(MOZ_MEMORY_LINUX) && !defined(MOZ_MEMORY_ANDROID)
 	pthread_mutexattr_t attr;
 	if (pthread_mutexattr_init(&attr) != 0)
 		return (true);
 	pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_ADAPTIVE_NP);
@@ -1289,17 +1288,17 @@ malloc_mutex_unlock(malloc_mutex_t *mute
 
 #if (defined(__GNUC__))
 __attribute__((unused))
 #  endif
 static bool
 malloc_spin_init(malloc_spinlock_t *lock)
 {
 #if defined(MOZ_MEMORY_WINDOWS)
-	if (! __crtInitCritSecAndSpinCount(lock, _CRT_SPINCOUNT))
+	if (!InitializeCriticalSectionAndSpinCount(lock, _CRT_SPINCOUNT))
 			return (true);
 #elif defined(MOZ_MEMORY_DARWIN)
 	lock->lock = OS_SPINLOCK_INIT;
 #elif defined(MOZ_MEMORY_LINUX) && !defined(MOZ_MEMORY_ANDROID)
 	pthread_mutexattr_t attr;
 	if (pthread_mutexattr_init(&attr) != 0)
 		return (true);
 	pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_ADAPTIVE_NP);