Bug 1365763 - Make all spidermonkey tasks depend on more file changes. r?sfink draft
authorMike Hommey <mh+mozilla@glandium.org>
Wed, 17 May 2017 18:51:12 +0900
changeset 579874 180cef0841a356c344931411a14371e996ba34ba
parent 579873 f3b98c909414b02100ba3022030c9dab3185b3f3
child 629136 f3a0a36855f73aa7266fb963bdc407747c37d086
push id59390
push userbmo:mh+mozilla@glandium.org
push dateWed, 17 May 2017 21:49:26 +0000
reviewerssfink
bugs1365763
milestone55.0a1
Bug 1365763 - Make all spidermonkey tasks depend on more file changes. r?sfink I've been bitten by spidermonkey tasks not running on automation enough. Anything that can have an influence on spidermonkey builds should trigger them to build, not only js/ changes. As it turns out, the sm-package task has a more complete list of things spidermonkey depends on, so we just use that same list for all tasks.
taskcluster/ci/spidermonkey/kind.yml
--- a/taskcluster/ci/spidermonkey/kind.yml
+++ b/taskcluster/ci/spidermonkey/kind.yml
@@ -22,55 +22,53 @@ job-defaults:
         max-run-time: 36000
         docker-image: {in-tree: desktop-build}
     run:
         using: spidermonkey
     when:
         files-changed:
             # any when.files-changed specified below in a job will be
             # appended to this list
+            - build/**
+            - config/**
+            - configure.py
+            - dom/bindings/**
+            - intl/icu/**
+            - js/moz.configure
             - js/public/**
             - js/src/**
+            - layout/tools/reftest/reftest/**
+            - Makefile.in
+            - media/webrtc/trunk/tools/gyp/**
+            - memory/**
+            - mfbt/**
+            - modules/fdlibm/**
+            - modules/zlib/src/**
+            - mozglue/**
+            - moz.build
+            - moz.configure
+            - nsprpub/**
+            - python/**
+            - taskcluster/moz.build
             - taskcluster/ci/spidermonkey/kind.yml
+            - testing/mozbase/**
+            - test.mozbuild
+            - toolkit/mozapps/installer/package-name.mk
+            - toolkit/mozapps/installer/upload-files.mk
 
 jobs:
     sm-package/opt:
         description: "Spidermonkey source package and test"
         index:
             job-name: sm-package-opt
         treeherder:
             symbol: SM-tc(pkg)
         run:
             using: spidermonkey-package
             spidermonkey-variant: plain
-        when:
-            files-changed:
-                - build/**
-                - config/**
-                - configure.py
-                - dom/bindings/**
-                - intl/icu/**
-                - js/moz.configure
-                - layout/tools/reftest/reftest/**
-                - Makefile.in
-                - media/webrtc/trunk/tools/gyp/**
-                - memory/**
-                - mfbt/**
-                - modules/fdlibm/**
-                - modules/zlib/src/**
-                - mozglue/**
-                - moz.build
-                - moz.configure
-                - nsprpub/**
-                - python/**
-                - taskcluster/moz.build
-                - testing/mozbase/**
-                - test.mozbuild
-                - toolkit/mozapps/installer/package-name.mk
-                - toolkit/mozapps/installer/upload-files.mk
 
     sm-mozjs-sys/debug:
         description: "Build js/src as the mozjs_sys Rust crate"
         index:
             job-name: sm-mozjs-sys-debug
         treeherder:
             platform: linux64/debug
             symbol: SM-tc(mozjs-crate)