Bug 1350036 - Clarify llvm-config detection error. r=froydnj
Reword the `llvm-config` detection error message to recommend setting the
LLVM_CONFIG env var, like we do for the bootstrap path. This avoids exposing
`clang` as well, so the compiler won't be changed.
MozReview-Commit-ID: CVNJ2bX2POa
--- a/toolkit/moz.configure
+++ b/toolkit/moz.configure
@@ -699,19 +699,21 @@ def stylo(stylo_enabled, bindgen_config_
return None
elif not bindgen_enabled:
return namespace(
enabled=bool(stylo_enabled)
)
elif not bindgen_config_paths:
die(dedent('''\
Could not find LLVM/Clang installation for compiling stylo build-time
- bindgen. Please put 'llvm-config' in your PATH, specify the
- 'LLVM_CONFIG' environment variable, or pass the '--with-libclang-path'
- and '--with-clang-path' options to configure.'''))
+ bindgen. Please specify the 'LLVM_CONFIG' environment variable
+ (recommended), pass the '--with-libclang-path' and '--with-clang-path'
+ options to configure, or put 'llvm-config' in your PATH. Altering your
+ PATH may expose 'clang' as well, potentially altering your compiler,
+ which may not be what you intended.'''))
return namespace(
enabled=bool(stylo_enabled),
libclang_path=bindgen_config_paths.libclang_path,
clang_path=bindgen_config_paths.clang_path,
bindgen_enabled=bool(bindgen_enabled),
)
