Bug 1365002 - Don't remove the back button background on state change. r=dao draft
authorJohann Hofmann <jhofmann@mozilla.com>
Tue, 16 May 2017 14:06:08 +0200
changeset 579568 2e8ba5bb849c202ffe7f42e1594c80b4ce9cd4bf
parent 579463 6e3ca5b38f7173b214b10de49e58cb01890bf39d
child 629047 c0f05391fc89952f6a327a19cbabc23cb077c3c5
push id59296
push userbmo:jhofmann@mozilla.com
push dateWed, 17 May 2017 13:16:09 +0000
reviewersdao
bugs1365002
milestone55.0a1
Bug 1365002 - Don't remove the back button background on state change. r=dao This CSS rule made certain actions on MacOS look strange, e.g. active without hover, and it doesn't appear to be needed on the other platforms since the background is always overriden when needed. MozReview-Commit-ID: Af6WnEspW5q
browser/themes/shared/toolbarbuttons.inc.css
--- a/browser/themes/shared/toolbarbuttons.inc.css
+++ b/browser/themes/shared/toolbarbuttons.inc.css
@@ -308,21 +308,17 @@ toolbarbutton.bookmark-item[open="true"]
   transition: background-color .4s;
 }
 
 %ifndef MOZ_PHOTON_THEME
 /* unified back/forward button */
 
 :-moz-any(#back-button, #forward-button) > .toolbarbutton-icon {
   border-color: var(--backbutton-border-color) !important;
-}
-
-:-moz-any(#back-button, #forward-button):not(:hover):not(:active):not([open=true]) > .toolbarbutton-icon,
-:-moz-any(#back-button, #forward-button)[disabled=true] > .toolbarbutton-icon {
-  background: var(--backbutton-background) !important;
+  background: var(--backbutton-background);
 }
 
 #forward-button {
   -moz-box-align: stretch; /* let the button shape grow vertically with the location bar */
   padding: 0 !important;
 }
 
 #forward-button > menupopup {
@@ -371,29 +367,23 @@ toolbarbutton.bookmark-item[open="true"]
 }
 
 #back-button > menupopup {
   margin-top: -1px !important;
 }
 
 #back-button > .toolbarbutton-icon {
 %ifdef MOZ_PHOTON_THEME
+  background: var(--backbutton-background);
   border-color: var(--backbutton-border-color) !important;
 %endif
   border-radius: 10000px !important;
   padding: 7px !important;
 }
 
-%ifdef MOZ_PHOTON_THEME
-#back-button:not(:hover):not(:active):not([open=true]) > .toolbarbutton-icon,
-#back-button[disabled=true] > .toolbarbutton-icon {
-  background: var(--backbutton-background) !important;
-}
-%endif
-
 /* bookmarks menu-button */
 
 #bookmarks-menu-button[cui-areatype="toolbar"] > .toolbarbutton-menubutton-dropmarker {
   -moz-appearance: none !important;
 }
 
 #nav-bar #bookmarks-menu-button[cui-areatype="toolbar"]:not([overflowedItem=true]) > .toolbarbutton-menubutton-dropmarker > .dropmarker-icon {
   padding-top: var(--toolbarbutton-inner-padding);