Bug 1348031: Part 2 - Accept fractional-millisecond profiling intervals in talos. r?mstange draft
authorKris Maglione <maglione.k@gmail.com>
Mon, 15 May 2017 09:20:53 -0700
changeset 578080 5f60d056202c8282b117c071ea78d9dfd13ee045
parent 578079 7d65c38c7ca74106b587d718609c687136c022a8
child 628683 43d14ad09084de3fbed02c53f4cb07a9ad879b61
push id58886
push usermaglione.k@gmail.com
push dateMon, 15 May 2017 21:25:33 +0000
reviewersmstange
bugs1348031
milestone55.0a1
Bug 1348031: Part 2 - Accept fractional-millisecond profiling intervals in talos. r?mstange MozReview-Commit-ID: 5LtLkKltbrL
testing/talos/talos/cmdline.py
--- a/testing/talos/talos/cmdline.py
+++ b/testing/talos/talos/cmdline.py
@@ -78,25 +78,25 @@ def create_parser(mach_interface=False):
     add_arg('--mainthread', action='store_true',
             help="Collect mainthread IO data from the browser by setting"
                  " an environment variable")
     add_arg("--mozAfterPaint", action='store_true', dest="tpmozafterpaint",
             help="wait for MozAfterPaint event before recording the time")
     add_arg('--spsProfile', action="store_true", dest="gecko_profile",
             help="(Deprecated - Use --geckoProfile instead.) Profile the "
                  "run and output the results in $MOZ_UPLOAD_DIR.")
-    add_arg('--spsProfileInterval', dest='gecko_profile_interval', type=int,
+    add_arg('--spsProfileInterval', dest='gecko_profile_interval', type=float,
             help="(Deprecated - Use --geckoProfileInterval instead.) How "
                  "frequently to take samples (ms)")
     add_arg('--spsProfileEntries', dest="gecko_profile_entries", type=int,
             help="(Deprecated - Use --geckoProfileEntries instead.) How "
                  "many samples to take with the profiler")
     add_arg('--geckoProfile', action="store_true", dest="gecko_profile",
             help="Profile the run and output the results in $MOZ_UPLOAD_DIR.")
-    add_arg('--geckoProfileInterval', dest='gecko_profile_interval', type=int,
+    add_arg('--geckoProfileInterval', dest='gecko_profile_interval', type=float,
             help="How frequently to take samples (ms)")
     add_arg('--geckoProfileEntries', dest="gecko_profile_entries", type=int,
             help="How many samples to take with the profiler")
     add_arg('--extension', dest='extensions', action='append',
             default=['${talos}/talos-powers/talos-powers-signed.xpi',
                      '${talos}/pageloader/pageloader-signed.xpi'],
             help="Extension to install while running")
     add_arg('--fast', action='store_true',