Bug 1364196 - Clean up code adding "nightly" to perfherder data; r?ted draft
authorGregory Szorc <gps@mozilla.com>
Thu, 11 May 2017 13:24:42 -0700
changeset 576549 d8a4ff182660094be94722439fbbc8bc7469c132
parent 576548 6ceba506b62a0ad3f92a4c35e178684bfdc77667
child 576550 dba3db2bd18345dc54a2585aaa71a28520c870ae
push id58399
push usergszorc@mozilla.com
push dateThu, 11 May 2017 20:28:55 +0000
reviewersted
bugs1364196
milestone55.0a1
Bug 1364196 - Clean up code adding "nightly" to perfherder data; r?ted I like fewer lines of code. MozReview-Commit-ID: 6WaOOCtubHX
testing/mozharness/mozharness/mozilla/building/buildbase.py
--- a/testing/mozharness/mozharness/mozilla/building/buildbase.py
+++ b/testing/mozharness/mozharness/mozilla/building/buildbase.py
@@ -2034,20 +2034,17 @@ or run without that action (ie: --no-{ac
 
         build_metrics = self._load_build_resources()
         if build_metrics:
             perfherder_data['suites'].append(build_metrics)
         perfherder_data['suites'].extend(self._load_sccache_stats())
 
         if self.query_is_nightly():
             for suite in perfherder_data['suites']:
-                if 'extraOptions' in suite:
-                    suite['extraOptions'] = ['nightly'] + suite['extraOptions']
-                else:
-                    suite['extraOptions'] = ['nightly']
+                suite.setdefault('extraOptions', []).insert(0, 'nightly')
 
         if perfherder_data["suites"]:
             self.info('PERFHERDER_DATA: %s' % json.dumps(perfherder_data))
 
     def sendchange(self):
         if os.environ.get('TASK_ID'):
             self.info("We are not running this in buildbot; skipping")
             return