Bug 1147271 - Add ssh option to prevent hanging on password prompt in upload.py r=mshal draft
authorChris Manchester <cmanchester@mozilla.com>
Thu, 11 May 2017 09:40:58 -0700
changeset 576398 80f753be34759a366a6cf10847a546f9484d40ca
parent 576334 3b96f277325747fe668ca8cd896d2f581238e4ee
child 628193 369c2c8705563acff15f60f4f6b374a50a9c80ca
push id58357
push userbmo:cmanchester@mozilla.com
push dateThu, 11 May 2017 18:18:27 +0000
reviewersmshal
bugs1147271
milestone55.0a1
Bug 1147271 - Add ssh option to prevent hanging on password prompt in upload.py r=mshal MozReview-Commit-ID: Lmg5SAtLuE3
build/upload.py
--- a/build/upload.py
+++ b/build/upload.py
@@ -85,16 +85,18 @@ def AppendOptionalArgsToSSHCommandline(c
     commandline arguments to the list cmdline if the values are not None."""
     if port is not None:
         cmdline.append("-P%d" % port)
     if ssh_key is not None:
         # Don't interpret ~ paths - ssh can handle that on its own
         if not ssh_key.startswith('~'):
             ssh_key = WindowsPathToMsysPath(ssh_key)
         cmdline.extend(["-o", "IdentityFile=%s" % ssh_key])
+    # In case of an issue here we don't want to hang on a password prompt.
+    cmdline.extend(["-o", "BatchMode=yes"])
 
 def DoSSHCommand(command, user, host, port=None, ssh_key=None):
     """Execute command on user@host using ssh. Optionally use
     port and ssh_key, if provided."""
     cmdline = ["ssh"]
     AppendOptionalArgsToSSHCommandline(cmdline, port, ssh_key)
     cmdline.extend(["%s@%s" % (user, host), command])