Bug 1363533 - Move heapsnapshot native components to /devtools/platform/heapsnapshot. r=fitzgen draft
authorAlexandre Poirot <poirot.alex@gmail.com>
Thu, 11 May 2017 10:38:04 +0200
changeset 576256 841592ae69332c2e3c02f7e16fa11146398374c6
parent 576255 cafe58ed01ae8b3950394aadb6293919d63bbcdb
child 628142 a5dcb612a75f41b54281410d921056fea5769351
push id58301
push userbmo:poirot.alex@gmail.com
push dateThu, 11 May 2017 14:32:51 +0000
reviewersfitzgen
bugs1363533
milestone55.0a1
Bug 1363533 - Move heapsnapshot native components to /devtools/platform/heapsnapshot. r=fitzgen MozReview-Commit-ID: Ljm33fuvE2T
devtools/platform/heapsnapshot/AutoMemMap.cpp
devtools/platform/heapsnapshot/AutoMemMap.h
devtools/platform/heapsnapshot/CoreDump.pb.cc
devtools/platform/heapsnapshot/CoreDump.pb.h
devtools/platform/heapsnapshot/CoreDump.proto
devtools/platform/heapsnapshot/DeserializedNode.cpp
devtools/platform/heapsnapshot/DeserializedNode.h
devtools/platform/heapsnapshot/DominatorTree.cpp
devtools/platform/heapsnapshot/DominatorTree.h
devtools/platform/heapsnapshot/FileDescriptorOutputStream.cpp
devtools/platform/heapsnapshot/FileDescriptorOutputStream.h
devtools/platform/heapsnapshot/HeapSnapshot.cpp
devtools/platform/heapsnapshot/HeapSnapshot.h
devtools/platform/heapsnapshot/HeapSnapshotTempFileHelperChild.h
devtools/platform/heapsnapshot/HeapSnapshotTempFileHelperParent.cpp
devtools/platform/heapsnapshot/HeapSnapshotTempFileHelperParent.h
devtools/platform/heapsnapshot/PHeapSnapshotTempFileHelper.ipdl
devtools/platform/heapsnapshot/ZeroCopyNSIOutputStream.cpp
devtools/platform/heapsnapshot/ZeroCopyNSIOutputStream.h
devtools/platform/heapsnapshot/generate-core-dump-sources.sh
devtools/platform/heapsnapshot/moz.build
devtools/platform/heapsnapshot/tests/gtest/DeserializedNodeUbiNodes.cpp
devtools/platform/heapsnapshot/tests/gtest/DeserializedStackFrameUbiStackFrames.cpp
devtools/platform/heapsnapshot/tests/gtest/DevTools.h
devtools/platform/heapsnapshot/tests/gtest/DoesCrossCompartmentBoundaries.cpp
devtools/platform/heapsnapshot/tests/gtest/DoesntCrossCompartmentBoundaries.cpp
devtools/platform/heapsnapshot/tests/gtest/SerializesEdgeNames.cpp
devtools/platform/heapsnapshot/tests/gtest/SerializesEverythingInHeapGraphOnce.cpp
devtools/platform/heapsnapshot/tests/gtest/SerializesTypeNames.cpp
devtools/platform/heapsnapshot/tests/gtest/moz.build
devtools/platform/heapsnapshot/tests/mochitest/.eslintrc.js
devtools/platform/heapsnapshot/tests/mochitest/chrome.ini
devtools/platform/heapsnapshot/tests/mochitest/mochitest.ini
devtools/platform/heapsnapshot/tests/mochitest/test_DominatorTree_01.html
devtools/platform/heapsnapshot/tests/mochitest/test_SaveHeapSnapshot.html
devtools/platform/heapsnapshot/tests/mochitest/test_saveHeapSnapshot_e10s_01.html
devtools/platform/moz.build
devtools/shared/heapsnapshot/AutoMemMap.cpp
devtools/shared/heapsnapshot/AutoMemMap.h
devtools/shared/heapsnapshot/CoreDump.pb.cc
devtools/shared/heapsnapshot/CoreDump.pb.h
devtools/shared/heapsnapshot/CoreDump.proto
devtools/shared/heapsnapshot/DeserializedNode.cpp
devtools/shared/heapsnapshot/DeserializedNode.h
devtools/shared/heapsnapshot/DominatorTree.cpp
devtools/shared/heapsnapshot/DominatorTree.h
devtools/shared/heapsnapshot/FileDescriptorOutputStream.cpp
devtools/shared/heapsnapshot/FileDescriptorOutputStream.h
devtools/shared/heapsnapshot/HeapSnapshot.cpp
devtools/shared/heapsnapshot/HeapSnapshot.h
devtools/shared/heapsnapshot/HeapSnapshotTempFileHelperChild.h
devtools/shared/heapsnapshot/HeapSnapshotTempFileHelperParent.cpp
devtools/shared/heapsnapshot/HeapSnapshotTempFileHelperParent.h
devtools/shared/heapsnapshot/PHeapSnapshotTempFileHelper.ipdl
devtools/shared/heapsnapshot/ZeroCopyNSIOutputStream.cpp
devtools/shared/heapsnapshot/ZeroCopyNSIOutputStream.h
devtools/shared/heapsnapshot/generate-core-dump-sources.sh
devtools/shared/heapsnapshot/moz.build
devtools/shared/heapsnapshot/tests/gtest/DeserializedNodeUbiNodes.cpp
devtools/shared/heapsnapshot/tests/gtest/DeserializedStackFrameUbiStackFrames.cpp
devtools/shared/heapsnapshot/tests/gtest/DevTools.h
devtools/shared/heapsnapshot/tests/gtest/DoesCrossCompartmentBoundaries.cpp
devtools/shared/heapsnapshot/tests/gtest/DoesntCrossCompartmentBoundaries.cpp
devtools/shared/heapsnapshot/tests/gtest/SerializesEdgeNames.cpp
devtools/shared/heapsnapshot/tests/gtest/SerializesEverythingInHeapGraphOnce.cpp
devtools/shared/heapsnapshot/tests/gtest/SerializesTypeNames.cpp
devtools/shared/heapsnapshot/tests/gtest/moz.build
devtools/shared/heapsnapshot/tests/mochitest/.eslintrc.js
devtools/shared/heapsnapshot/tests/mochitest/chrome.ini
devtools/shared/heapsnapshot/tests/mochitest/mochitest.ini
devtools/shared/heapsnapshot/tests/mochitest/test_DominatorTree_01.html
devtools/shared/heapsnapshot/tests/mochitest/test_SaveHeapSnapshot.html
devtools/shared/heapsnapshot/tests/mochitest/test_saveHeapSnapshot_e10s_01.html
rename from devtools/shared/heapsnapshot/AutoMemMap.cpp
rename to devtools/platform/heapsnapshot/AutoMemMap.cpp
rename from devtools/shared/heapsnapshot/AutoMemMap.h
rename to devtools/platform/heapsnapshot/AutoMemMap.h
rename from devtools/shared/heapsnapshot/CoreDump.pb.cc
rename to devtools/platform/heapsnapshot/CoreDump.pb.cc
rename from devtools/shared/heapsnapshot/CoreDump.pb.h
rename to devtools/platform/heapsnapshot/CoreDump.pb.h
rename from devtools/shared/heapsnapshot/CoreDump.proto
rename to devtools/platform/heapsnapshot/CoreDump.proto
rename from devtools/shared/heapsnapshot/DeserializedNode.cpp
rename to devtools/platform/heapsnapshot/DeserializedNode.cpp
rename from devtools/shared/heapsnapshot/DeserializedNode.h
rename to devtools/platform/heapsnapshot/DeserializedNode.h
rename from devtools/shared/heapsnapshot/DominatorTree.cpp
rename to devtools/platform/heapsnapshot/DominatorTree.cpp
rename from devtools/shared/heapsnapshot/DominatorTree.h
rename to devtools/platform/heapsnapshot/DominatorTree.h
rename from devtools/shared/heapsnapshot/FileDescriptorOutputStream.cpp
rename to devtools/platform/heapsnapshot/FileDescriptorOutputStream.cpp
rename from devtools/shared/heapsnapshot/FileDescriptorOutputStream.h
rename to devtools/platform/heapsnapshot/FileDescriptorOutputStream.h
rename from devtools/shared/heapsnapshot/HeapSnapshot.cpp
rename to devtools/platform/heapsnapshot/HeapSnapshot.cpp
rename from devtools/shared/heapsnapshot/HeapSnapshot.h
rename to devtools/platform/heapsnapshot/HeapSnapshot.h
rename from devtools/shared/heapsnapshot/HeapSnapshotTempFileHelperChild.h
rename to devtools/platform/heapsnapshot/HeapSnapshotTempFileHelperChild.h
rename from devtools/shared/heapsnapshot/HeapSnapshotTempFileHelperParent.cpp
rename to devtools/platform/heapsnapshot/HeapSnapshotTempFileHelperParent.cpp
rename from devtools/shared/heapsnapshot/HeapSnapshotTempFileHelperParent.h
rename to devtools/platform/heapsnapshot/HeapSnapshotTempFileHelperParent.h
rename from devtools/shared/heapsnapshot/PHeapSnapshotTempFileHelper.ipdl
rename to devtools/platform/heapsnapshot/PHeapSnapshotTempFileHelper.ipdl
rename from devtools/shared/heapsnapshot/ZeroCopyNSIOutputStream.cpp
rename to devtools/platform/heapsnapshot/ZeroCopyNSIOutputStream.cpp
rename from devtools/shared/heapsnapshot/ZeroCopyNSIOutputStream.h
rename to devtools/platform/heapsnapshot/ZeroCopyNSIOutputStream.h
rename from devtools/shared/heapsnapshot/generate-core-dump-sources.sh
rename to devtools/platform/heapsnapshot/generate-core-dump-sources.sh
new file mode 100644
--- /dev/null
+++ b/devtools/platform/heapsnapshot/moz.build
@@ -0,0 +1,51 @@
+# -*- Mode: python; indent-tabs-mode: nil; tab-width: 40 -*-
+# vim: set filetype=python:
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+with Files('**'):
+    BUG_COMPONENT = ('Firefox', 'Developer Tools: Memory')
+
+if CONFIG['ENABLE_TESTS']:
+    DIRS += ['tests/gtest']
+
+MOCHITEST_MANIFESTS += [ 'tests/mochitest/mochitest.ini' ]
+MOCHITEST_CHROME_MANIFESTS += [ 'tests/mochitest/chrome.ini' ]
+
+EXPORTS.mozilla.devtools += [
+    'AutoMemMap.h',
+    'CoreDump.pb.h',
+    'DeserializedNode.h',
+    'DominatorTree.h',
+    'FileDescriptorOutputStream.h',
+    'HeapSnapshot.h',
+    'HeapSnapshotTempFileHelperChild.h',
+    'HeapSnapshotTempFileHelperParent.h',
+    'ZeroCopyNSIOutputStream.h',
+]
+
+IPDL_SOURCES += [
+    'PHeapSnapshotTempFileHelper.ipdl',
+]
+
+include('/ipc/chromium/chromium-config.mozbuild')
+
+SOURCES += [
+    'AutoMemMap.cpp',
+    'CoreDump.pb.cc',
+    'DeserializedNode.cpp',
+    'DominatorTree.cpp',
+    'FileDescriptorOutputStream.cpp',
+    'HeapSnapshot.cpp',
+    'HeapSnapshotTempFileHelperParent.cpp',
+    'ZeroCopyNSIOutputStream.cpp',
+]
+
+# Disable RTTI in google protocol buffer
+DEFINES['GOOGLE_PROTOBUF_NO_RTTI'] = True
+
+FINAL_LIBRARY = 'xul'
+
+if CONFIG['GNU_CXX']:
+    CXXFLAGS += ['-Wno-error=shadow']
rename from devtools/shared/heapsnapshot/tests/gtest/DeserializedNodeUbiNodes.cpp
rename to devtools/platform/heapsnapshot/tests/gtest/DeserializedNodeUbiNodes.cpp
rename from devtools/shared/heapsnapshot/tests/gtest/DeserializedStackFrameUbiStackFrames.cpp
rename to devtools/platform/heapsnapshot/tests/gtest/DeserializedStackFrameUbiStackFrames.cpp
rename from devtools/shared/heapsnapshot/tests/gtest/DevTools.h
rename to devtools/platform/heapsnapshot/tests/gtest/DevTools.h
rename from devtools/shared/heapsnapshot/tests/gtest/DoesCrossCompartmentBoundaries.cpp
rename to devtools/platform/heapsnapshot/tests/gtest/DoesCrossCompartmentBoundaries.cpp
rename from devtools/shared/heapsnapshot/tests/gtest/DoesntCrossCompartmentBoundaries.cpp
rename to devtools/platform/heapsnapshot/tests/gtest/DoesntCrossCompartmentBoundaries.cpp
rename from devtools/shared/heapsnapshot/tests/gtest/SerializesEdgeNames.cpp
rename to devtools/platform/heapsnapshot/tests/gtest/SerializesEdgeNames.cpp
rename from devtools/shared/heapsnapshot/tests/gtest/SerializesEverythingInHeapGraphOnce.cpp
rename to devtools/platform/heapsnapshot/tests/gtest/SerializesEverythingInHeapGraphOnce.cpp
rename from devtools/shared/heapsnapshot/tests/gtest/SerializesTypeNames.cpp
rename to devtools/platform/heapsnapshot/tests/gtest/SerializesTypeNames.cpp
rename from devtools/shared/heapsnapshot/tests/gtest/moz.build
rename to devtools/platform/heapsnapshot/tests/gtest/moz.build
rename from devtools/shared/heapsnapshot/tests/mochitest/.eslintrc.js
rename to devtools/platform/heapsnapshot/tests/mochitest/.eslintrc.js
rename from devtools/shared/heapsnapshot/tests/mochitest/chrome.ini
rename to devtools/platform/heapsnapshot/tests/mochitest/chrome.ini
rename from devtools/shared/heapsnapshot/tests/mochitest/mochitest.ini
rename to devtools/platform/heapsnapshot/tests/mochitest/mochitest.ini
rename from devtools/shared/heapsnapshot/tests/mochitest/test_DominatorTree_01.html
rename to devtools/platform/heapsnapshot/tests/mochitest/test_DominatorTree_01.html
rename from devtools/shared/heapsnapshot/tests/mochitest/test_SaveHeapSnapshot.html
rename to devtools/platform/heapsnapshot/tests/mochitest/test_SaveHeapSnapshot.html
rename from devtools/shared/heapsnapshot/tests/mochitest/test_saveHeapSnapshot_e10s_01.html
rename to devtools/platform/heapsnapshot/tests/mochitest/test_saveHeapSnapshot_e10s_01.html
--- a/devtools/platform/moz.build
+++ b/devtools/platform/moz.build
@@ -1,14 +1,18 @@
 # -*- Mode: python; indent-tabs-mode: nil; tab-width: 40 -*-
 # vim: set filetype=python:
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+DIRS += [
+    'heapsnapshot',
+]
+
 XPCSHELL_TESTS_MANIFESTS += ['tests/unit/xpcshell.ini']
 
 XPIDL_SOURCES += [
     'nsIJSInspector.idl',
 ]
 
 XPIDL_MODULE = 'jsinspector'
 
--- a/devtools/shared/heapsnapshot/moz.build
+++ b/devtools/shared/heapsnapshot/moz.build
@@ -2,61 +2,19 @@
 # vim: set filetype=python:
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 with Files('**'):
     BUG_COMPONENT = ('Firefox', 'Developer Tools: Memory')
 
-if CONFIG['ENABLE_TESTS']:
-    DIRS += ['tests/gtest']
-
 XPCSHELL_TESTS_MANIFESTS += [ 'tests/unit/xpcshell.ini' ]
-MOCHITEST_MANIFESTS += [ 'tests/mochitest/mochitest.ini' ]
-MOCHITEST_CHROME_MANIFESTS += [ 'tests/mochitest/chrome.ini' ]
-
-EXPORTS.mozilla.devtools += [
-    'AutoMemMap.h',
-    'CoreDump.pb.h',
-    'DeserializedNode.h',
-    'DominatorTree.h',
-    'FileDescriptorOutputStream.h',
-    'HeapSnapshot.h',
-    'HeapSnapshotTempFileHelperChild.h',
-    'HeapSnapshotTempFileHelperParent.h',
-    'ZeroCopyNSIOutputStream.h',
-]
-
-IPDL_SOURCES += [
-    'PHeapSnapshotTempFileHelper.ipdl',
-]
-
-include('/ipc/chromium/chromium-config.mozbuild')
-
-SOURCES += [
-    'AutoMemMap.cpp',
-    'CoreDump.pb.cc',
-    'DeserializedNode.cpp',
-    'DominatorTree.cpp',
-    'FileDescriptorOutputStream.cpp',
-    'HeapSnapshot.cpp',
-    'HeapSnapshotTempFileHelperParent.cpp',
-    'ZeroCopyNSIOutputStream.cpp',
-]
-
-# Disable RTTI in google protocol buffer
-DEFINES['GOOGLE_PROTOBUF_NO_RTTI'] = True
-
-FINAL_LIBRARY = 'xul'
 
 DevToolsModules(
     'census-tree-node.js',
     'CensusUtils.js',
     'DominatorTreeNode.js',
     'HeapAnalysesClient.js',
     'HeapAnalysesWorker.js',
     'HeapSnapshotFileUtils.js',
     'shortest-paths.js',
 )
-
-if CONFIG['GNU_CXX']:
-    CXXFLAGS += ['-Wno-error=shadow']